* [PATCH] Bugfix: Functions were renamed so rename the callers too
@ 2009-01-13 23:34 Bernt Hansen
2009-01-13 23:37 ` Carsten Dominik
0 siblings, 1 reply; 4+ messages in thread
From: Bernt Hansen @ 2009-01-13 23:34 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Rename functions missed in commit 1371205.
Changing timestamps for the currently clocked task generated the
following error:
org-clock-update-time-maybe: Symbol's function definition is void: org-update-mode-line
---
I sent this patch to the list a day or two ago but it looks like it
never made it so here's a resend.
Carsten: This commit is available in my 'for-carsten' branch.
Regards,
Bernt
lisp/org.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index f9db516..125c4f3 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2665,7 +2665,7 @@ If TABLE-TYPE is non-nil, also check for table.el-type tables."
(declare-function org-clock-save-markers-for-cut-and-paste "org-clock"
(beg end))
-(declare-function org-update-mode-line "org-clock" ())
+(declare-function org-clock-update-mode-line "org-clock" ())
(defvar org-clock-start-time)
(defvar org-clock-marker (make-marker)
"Marker recording the last clock-in.")
@@ -2702,7 +2702,7 @@ Otherwise, return nil."
(setq org-clock-start-time
(apply 'encode-time
(org-parse-time-string (match-string 1))))
- (org-update-mode-line)))
+ (org-clock-update-mode-line)))
(t
(and (match-end 4) (delete-region (match-beginning 4) (match-end 4)))
(end-of-line 1)
--
1.6.1.28.gc32f76
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Bugfix: Functions were renamed so rename the callers too
2009-01-13 23:34 [PATCH] Bugfix: Functions were renamed so rename the callers too Bernt Hansen
@ 2009-01-13 23:37 ` Carsten Dominik
0 siblings, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2009-01-13 23:37 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode@gnu.org list
Thanks!
- Carsten
On Jan 14, 2009, at 12:34 AM, Bernt Hansen wrote:
> Rename functions missed in commit 1371205.
>
> Changing timestamps for the currently clocked task generated the
> following error:
>
> org-clock-update-time-maybe: Symbol's function definition is void:
> org-update-mode-line
> ---
> I sent this patch to the list a day or two ago but it looks like it
> never made it so here's a resend.
>
> Carsten: This commit is available in my 'for-carsten' branch.
>
> Regards,
> Bernt
>
> lisp/org.el | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index f9db516..125c4f3 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -2665,7 +2665,7 @@ If TABLE-TYPE is non-nil, also check for
> table.el-type tables."
>
> (declare-function org-clock-save-markers-for-cut-and-paste "org-clock"
> (beg end))
> -(declare-function org-update-mode-line "org-clock" ())
> +(declare-function org-clock-update-mode-line "org-clock" ())
> (defvar org-clock-start-time)
> (defvar org-clock-marker (make-marker)
> "Marker recording the last clock-in.")
> @@ -2702,7 +2702,7 @@ Otherwise, return nil."
> (setq org-clock-start-time
> (apply 'encode-time
> (org-parse-time-string (match-string 1))))
> - (org-update-mode-line)))
> + (org-clock-update-mode-line)))
> (t
> (and (match-end 4) (delete-region (match-beginning 4) (match-end
> 4)))
> (end-of-line 1)
> --
> 1.6.1.28.gc32f76
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Bugfix: Functions were renamed so rename the callers too
@ 2009-01-12 20:00 Bernt Hansen
2009-01-18 16:00 ` Bernt Hansen
0 siblings, 1 reply; 4+ messages in thread
From: Bernt Hansen @ 2009-01-12 20:00 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Bernt Hansen
Rename functions missed in commit 1371205.
Changing timestamps for the currently clocked task generated the
following error:
org-clock-update-time-maybe: Symbol's function definition is void: org-update-mode-line
---
Carsten: This patch is available on my 'for-carsten' branch.
lisp/org.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index c33560e..8539f94 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2665,7 +2665,7 @@ If TABLE-TYPE is non-nil, also check for table.el-type tables."
(declare-function org-clock-save-markers-for-cut-and-paste "org-clock"
(beg end))
-(declare-function org-update-mode-line "org-clock" ())
+(declare-function org-clock-update-mode-line "org-clock" ())
(defvar org-clock-start-time)
(defvar org-clock-marker (make-marker)
"Marker recording the last clock-in.")
@@ -2702,7 +2702,7 @@ Otherwise, return nil."
(setq org-clock-start-time
(apply 'encode-time
(org-parse-time-string (match-string 1))))
- (org-update-mode-line)))
+ (org-clock-update-mode-line)))
(t
(and (match-end 4) (delete-region (match-beginning 4) (match-end 4)))
(end-of-line 1)
--
1.6.1.28.gc32f76
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Bugfix: Functions were renamed so rename the callers too
2009-01-12 20:00 Bernt Hansen
@ 2009-01-18 16:00 ` Bernt Hansen
0 siblings, 0 replies; 4+ messages in thread
From: Bernt Hansen @ 2009-01-18 16:00 UTC (permalink / raw)
To: emacs-orgmode
This is old and already applied. Thanks.
This was my original submission sent by git send-email. I assume it got
stuck waiting for moderation before it hit the list.
-Bernt
Bernt Hansen <bernt@norang.ca> writes:
> Rename functions missed in commit 1371205.
>
> Changing timestamps for the currently clocked task generated the
> following error:
>
> org-clock-update-time-maybe: Symbol's function definition is void: org-update-mode-line
> ---
> Carsten: This patch is available on my 'for-carsten' branch.
>
> lisp/org.el | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index c33560e..8539f94 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -2665,7 +2665,7 @@ If TABLE-TYPE is non-nil, also check for table.el-type tables."
>
> (declare-function org-clock-save-markers-for-cut-and-paste "org-clock"
> (beg end))
> -(declare-function org-update-mode-line "org-clock" ())
> +(declare-function org-clock-update-mode-line "org-clock" ())
> (defvar org-clock-start-time)
> (defvar org-clock-marker (make-marker)
> "Marker recording the last clock-in.")
> @@ -2702,7 +2702,7 @@ Otherwise, return nil."
> (setq org-clock-start-time
> (apply 'encode-time
> (org-parse-time-string (match-string 1))))
> - (org-update-mode-line)))
> + (org-clock-update-mode-line)))
> (t
> (and (match-end 4) (delete-region (match-beginning 4) (match-end 4)))
> (end-of-line 1)
> --
> 1.6.1.28.gc32f76
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-18 16:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 23:34 [PATCH] Bugfix: Functions were renamed so rename the callers too Bernt Hansen
2009-01-13 23:37 ` Carsten Dominik
-- strict thread matches above, loose matches on Subject: below --
2009-01-12 20:00 Bernt Hansen
2009-01-18 16:00 ` Bernt Hansen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).