From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: [PATCH] comments exporting Date: Mon, 14 Jun 2010 14:36:50 -0700 Message-ID: <87d3vt47oq.fsf@gmail.com> References: <87ljaitszr.wl%n.goaziou@gmail.com> <87d3vtwmdg.fsf@gmail.com> <87mxuxiixc.fsf@gmail.com> <87iq5ltm2g.wl%n.goaziou@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=53451 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOHLX-0001ii-6O for emacs-orgmode@gnu.org; Mon, 14 Jun 2010 17:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOHLV-0006v6-PX for emacs-orgmode@gnu.org; Mon, 14 Jun 2010 17:37:30 -0400 Received: from mail-pv0-f169.google.com ([74.125.83.169]:40540) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOHLV-0006v0-L8 for emacs-orgmode@gnu.org; Mon, 14 Jun 2010 17:37:29 -0400 Received: by pvg3 with SMTP id 3so23536pvg.0 for ; Mon, 14 Jun 2010 14:37:28 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Hi Nicolas, Nicolas Goaziou writes: >>>>>> Eric Schulte writes: > >> A potentially related issue, >> The following org-mode snippet doesn't export correctly to latex, >> presumably because of protection issues similar to those addressed in >> your patch. Any ideas? > >> --8<---------------cut here---------------start------------->8--- >> ** comments not commented > >> # $some stuff >> # some more stuff$ -- I should be a comment line >> --8<---------------cut here---------------end--------------->8--- > > Yes. > > Actually, the latex stuff is processed before taking care of comments > (one of the last actions in every exporter). So the $...$ snippet is > matched by org-latex and protected. > > This patch removes protection check from comment deletion : something > in comment must not be exported anyway. I don't see any corner case > right now. > Great. Thanks for the continuous flow of useful patches. Not to look a gift patch in the mouth, but while this patch fixes the above issue it looks like it introduces a new problem. Before the patch the following --8<---------------cut here---------------start------------->8--- ** comments not commented # $some stuff # some more stuff$ -- I should be a comment line 1) a source block inside of an =enumerate= #+source: plotxy #+begin_src emacs-lisp :exports results (message "I think so") #+end_src can cause problems --8<---------------cut here---------------end--------------->8--- exports to --8<---------------cut here---------------start------------->8--- \section{comments not commented} \label{sec-1} # some more stuff$ -- I should be a comment line \begin{enumerate} \item a source block inside of an \texttt{enumerate} \begin{verbatim} I think so \end{verbatim} can cause problems \end{enumerate} --8<---------------cut here---------------end--------------->8--- while after the patch it exports to --8<---------------cut here---------------start------------->8--- \section{comments not commented} \label{sec-1} \begin{enumerate} \item a source block inside of an \texttt{enumerate} \#+source: plotxy \#+results: plotxy \begin{verbatim} I think so \end{verbatim} can cause problems \end{enumerate} --8<---------------cut here---------------end--------------->8--- which is wrong in a different way. > >>> This patch looks great. Since it's >10 lines long, I must ask if you've >>> signed the FSF papers for contributions to Emacs? If not is that >>> something you're willing to do? > > I have sent the signed papers last Wednesday (I had to since my patch > for org-babel-asymptote). I'm now waiting for their mail. > Oh, how forgetful of me, there's a todo in my agenda with your name on it about checking up on the status of the FSF papers. Thanks! -- Eric > > Regards, > > -- > Nicolas