emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
@ 2010-07-05 10:28 Tassilo Horn
  2010-07-05 12:41 ` Bernt Hansen
  0 siblings, 1 reply; 10+ messages in thread
From: Tassilo Horn @ 2010-07-05 10:28 UTC (permalink / raw)
  To: emacs-orgmode


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

I have a lot of repeating entries like that:

--8<---------------cut here---------------start------------->8---
**** Treffen GST SS 2010
     <2010-05-17 Mon 14:30-15:30 +1w>
--8<---------------cut here---------------end--------------->8---

Unfortunately, with the current git HEAD, those don't show up in the
agenda.  When I delete the repeater, they are back again, but of course
only for that date.

I did a git bisection, and this is the commit that broke the agenda.

--8<---------------cut here---------------start------------->8---
516640aff96b627d8ad412f6cdb436535600aff0 is the first bad commit
commit 516640aff96b627d8ad412f6cdb436535600aff0
Author: Bernt Hansen <bernt@norang.ca>
Date:   Wed Jun 23 02:40:16 2010 +0000

    Fix agenda display for late scheduled and deadline tasks
    
    * lisp/org.el (org-time-string-to-absolute): Ignore cyclic repeater
    when displaying items on todays agenda date.
    
    Ignore the cyclic repeater when displaying items on today's agenda
    date.  If you have a weekly task and miss the date the agenda view
    will show more than a week late now instead of resetting on the
    cyclic repeating date.  This makes it much more obvious when you
    missed a repeating task after the repeater.

:040000 040000 6adc4989048178b44594a7819da10c3294b9dd8a
59814d17696a962c77b145005033beee8b1e07f2 M       lisp
--8<---------------cut here---------------end--------------->8---


Emacs  : GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2010-06-29 on thinkpad
Package: Org-mode version 6.36trans (release_6.36.509.g9e9b)

current state:
==============
(setq
 org-log-done 'time
 org-archive-default-command 'org-archive-set-tag
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-link-frame-setup '((vm . vm-visit-folder) (gnus . org-gnus-no-new-news) (file . find-file-other-window))
 org-special-ctrl-a/e 'reversed
 org-agenda-files '("/home/horn/repos/org")
 org-agenda-include-diary t
 org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
 org-gnus-prefer-web-links t
 org-fontify-whole-heading-line t
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-attach-directory "/home/horn/repos/org/attachments"
 org-special-ctrl-k t
 org-agenda-time-leading-zero t
 org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
 org-agenda-restore-windows-after-quit t
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-export-preprocess-hook '(org-export-blocks-preprocess)
 org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe)
 org-src-mode-hook '(org-src-mode-configure-edit-buffer)
 org-finalize-agenda-hook '(th-org-agenda-to-appt)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-todo-keywords '((sequence "TODO(t)" "STARTED(s)" "DELEGATED(g)" "IDEA(i)" "|" "DONE(d)" "CANCELLED(c)"))
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-directory "/home/horn/repos/org"
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
 org-mode-hook '(th-org-mode-init
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-refile-targets '((org-agenda-files :maxlevel . 5))
 org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe org-babel-hash-at-point org-babel-execute-src-block-maybe)
 org-complete-tags-always-offer-all-agenda-tags t
 org-return-follows-link t
 org-confirm-elisp-link-function 'yes-or-no-p
 org-refile-use-outline-path 'file
 org-log-into-drawer "LOGBOOK"
 org-icalendar-categories '(all-tags category)
 org-agenda-mode-hook '(th-org-agenda-mode-init)
 org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org-babel-exp-inline-src-blocks))
 org-enforce-todo-dependencies t
 org-refile-allow-creating-parent-nodes 'confirm
 org-occur-hook '(org-first-headline-recenter)
 org-icalendar-include-body t
 org-agenda-skip-additional-timestamps-same-entry nil
 org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
 org-modules '(org-attach org-protocol org-id org-bbdb org-bibtex org-docview org-gnus org-info org-jsinfo org-irc
               org-w3m)
 org-columns-default-format "%50ITEM %TODO %ALLTAGS %SCHEDULED %DEADLINE"
 outline-minor-mode-hook '(th-outline-minor-mode-init)
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames
                               org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-attach-method 'mv
 org-export-blocks '((src org-babel-exp-src-blocks nil) (comment org-export-blocks-format-comment t)
                     (ditaa org-export-blocks-format-ditaa nil) (dot org-export-blocks-format-dot nil))
 )

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 10:28 Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)] Tassilo Horn
@ 2010-07-05 12:41 ` Bernt Hansen
  2010-07-05 13:19   ` Tassilo Horn
  2010-07-05 20:30   ` Tassilo Horn
  0 siblings, 2 replies; 10+ messages in thread
From: Bernt Hansen @ 2010-07-05 12:41 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: emacs-orgmode

Tassilo Horn <thorn@fastmail.fm> writes:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>      http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> I have a lot of repeating entries like that:
>
> --8<---------------cut here---------------start------------->8---
> **** Treffen GST SS 2010
>      <2010-05-17 Mon 14:30-15:30 +1w>
> --8<---------------cut here---------------end--------------->8---
>
> Unfortunately, with the current git HEAD, those don't show up in the
> agenda.  When I delete the repeater, they are back again, but of course
> only for that date.
>
> I did a git bisection, and this is the commit that broke the agenda.
>
> --8<---------------cut here---------------start------------->8---
> 516640aff96b627d8ad412f6cdb436535600aff0 is the first bad commit
> commit 516640aff96b627d8ad412f6cdb436535600aff0
> Author: Bernt Hansen <bernt@norang.ca>
> Date:   Wed Jun 23 02:40:16 2010 +0000
>
>     Fix agenda display for late scheduled and deadline tasks
>     
>     * lisp/org.el (org-time-string-to-absolute): Ignore cyclic repeater
>     when displaying items on todays agenda date.
>     
>     Ignore the cyclic repeater when displaying items on today's agenda
>     date.  If you have a weekly task and miss the date the agenda view
>     will show more than a week late now instead of resetting on the
>     cyclic repeating date.  This makes it much more obvious when you
>     missed a repeating task after the repeater.
>
> :040000 040000 6adc4989048178b44594a7819da10c3294b9dd8a
> 59814d17696a962c77b145005033beee8b1e07f2 M       lisp
> --8<---------------cut here---------------end--------------->8---
>
>
> Emacs  : GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1)
>  of 2010-06-29 on thinkpad
> Package: Org-mode version 6.36trans (release_6.36.509.g9e9b)
>
> current state:
> ==============
> (setq
>  org-log-done 'time
>  org-archive-default-command 'org-archive-set-tag
>  org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
>  org-link-frame-setup '((vm . vm-visit-folder) (gnus . org-gnus-no-new-news) (file . find-file-other-window))
>  org-special-ctrl-a/e 'reversed
>  org-agenda-files '("/home/horn/repos/org")
>  org-agenda-include-diary t
>  org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
>  org-gnus-prefer-web-links t
>  org-fontify-whole-heading-line t
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  org-after-todo-state-change-hook '(org-clock-out-if-current)
>  org-attach-directory "/home/horn/repos/org/attachments"
>  org-special-ctrl-k t
>  org-agenda-time-leading-zero t
>  org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
>  org-agenda-restore-windows-after-quit t
>  org-export-latex-format-toc-function 'org-export-latex-format-toc-default
>  org-export-preprocess-hook '(org-export-blocks-preprocess)
>  org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe)
>  org-src-mode-hook '(org-src-mode-configure-edit-buffer)
>  org-finalize-agenda-hook '(th-org-agenda-to-appt)
>  org-confirm-shell-link-function 'yes-or-no-p
>  org-export-first-hook '(org-beamer-initialize-open-trackers)
>  org-todo-keywords '((sequence "TODO(t)" "STARTED(s)" "DELEGATED(g)" "IDEA(i)" "|" "DONE(d)" "CANCELLED(c)"))
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-directory "/home/horn/repos/org"
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
>                   org-optimize-window-after-visibility-change)
>  org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
>  org-mode-hook '(th-org-mode-init
>                  #[nil "\300\301\302\303\304$\207"
>                    [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
>                  #[nil "\300\301\302\303\304$\207"
>                    [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
>                  org-babel-result-hide-spec org-babel-hide-all-hashes)
>  org-refile-targets '((org-agenda-files :maxlevel . 5))
>  org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe org-babel-hash-at-point org-babel-execute-src-block-maybe)
>  org-complete-tags-always-offer-all-agenda-tags t
>  org-return-follows-link t
>  org-confirm-elisp-link-function 'yes-or-no-p
>  org-refile-use-outline-path 'file
>  org-log-into-drawer "LOGBOOK"
>  org-icalendar-categories '(all-tags category)
>  org-agenda-mode-hook '(th-org-agenda-mode-init)
>  org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org-babel-exp-inline-src-blocks))
>  org-enforce-todo-dependencies t
>  org-refile-allow-creating-parent-nodes 'confirm
>  org-occur-hook '(org-first-headline-recenter)
>  org-icalendar-include-body t
>  org-agenda-skip-additional-timestamps-same-entry nil
>  org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
>  org-modules '(org-attach org-protocol org-id org-bbdb org-bibtex org-docview org-gnus org-info org-jsinfo org-irc
>                org-w3m)
>  org-columns-default-format "%50ITEM %TODO %ALLTAGS %SCHEDULED %DEADLINE"
>  outline-minor-mode-hook '(th-outline-minor-mode-init)
>  org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames
>                                org-beamer-place-default-actions-for-lists)
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-attach-method 'mv
>  org-export-blocks '((src org-babel-exp-src-blocks nil) (comment org-export-blocks-format-comment t)
>                      (ditaa org-export-blocks-format-ditaa nil) (dot org-export-blocks-format-dot nil))
>  )

Hi Tassilo

This works for me in both

GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian
Org-mode version 6.36trans (release_6.36.509.g9e9b)

and 

GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1,
Org-mode version 6.36trans (release_6.36.509.g9e9b)

Do you have org-agenda-repeating-timestamp-show-all set to t?

-Bernt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 12:41 ` Bernt Hansen
@ 2010-07-05 13:19   ` Tassilo Horn
  2010-07-05 17:55     ` Tassilo Horn
  2010-07-05 20:30   ` Tassilo Horn
  1 sibling, 1 reply; 10+ messages in thread
From: Tassilo Horn @ 2010-07-05 13:19 UTC (permalink / raw)
  To: emacs-orgmode

Bernt Hansen <bernt@norang.ca> writes:

Hi Bernt,

> This works for me in both
>
> GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian
> Org-mode version 6.36trans (release_6.36.509.g9e9b)
>
> and 
>
> GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1,
> Org-mode version 6.36trans (release_6.36.509.g9e9b)

I use

GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of
2010-06-29 on thinkpad

and the current org git HEAD.  Unfortunately, I don't have a clue what
might cause this problem.  If you have any idea, I'm happy to edebug
anything you want or provide any additional information.

> Do you have org-agenda-repeating-timestamp-show-all set to t?

Yes, I use the default value which is t.

Bye,
Tassilo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 13:19   ` Tassilo Horn
@ 2010-07-05 17:55     ` Tassilo Horn
  2010-07-05 19:43       ` Bernt Hansen
  0 siblings, 1 reply; 10+ messages in thread
From: Tassilo Horn @ 2010-07-05 17:55 UTC (permalink / raw)
  To: emacs-orgmode

Tassilo Horn <tassilo@member.fsf.org> writes:

Hi again,

>> This works for me in both
>>
>> GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian
>> Org-mode version 6.36trans (release_6.36.509.g9e9b)
>>
>> and 
>>
>> GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1,
>> Org-mode version 6.36trans (release_6.36.509.g9e9b)
>
> I use
>
> GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of
> 2010-06-29 on thinkpad
>
> and the current org git HEAD.

Now I tried Emacs 23.2, and the problem still persists.  Did you do a
"make clean" before "make" in org to exclude the possibility of having
old (but working) *.elc files around?

Bye,
Tassilo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 17:55     ` Tassilo Horn
@ 2010-07-05 19:43       ` Bernt Hansen
  0 siblings, 0 replies; 10+ messages in thread
From: Bernt Hansen @ 2010-07-05 19:43 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: emacs-orgmode

Tassilo Horn <tassilo@member.fsf.org> writes:

> Tassilo Horn <tassilo@member.fsf.org> writes:
>
> Hi again,
>
>>> This works for me in both
>>>
>>> GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-09 on raven, modified by Debian
>>> Org-mode version 6.36trans (release_6.36.509.g9e9b)
>>>
>>> and 
>>>
>>> GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1,
>>> Org-mode version 6.36trans (release_6.36.509.g9e9b)
>>
>> I use
>>
>> GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of
>> 2010-06-29 on thinkpad
>>
>> and the current org git HEAD.
>
> Now I tried Emacs 23.2, and the problem still persists.  Did you do a
> "make clean" before "make" in org to exclude the possibility of having
> old (but working) *.elc files around?

I have no .elc files - I run directly from the source files (which
greatly simplifies jumping around on different commits when I'm trying
things)

Does reverting that commit locally fix it for you?

Do I understand the problem correctly?  If I use your example entry (by
sticking it at a level 1 task in my refile.org and doing v m in the
agenda to show all entries for the month I see the future entries in my
agenda but you don't?

I'm confused.

-Bernt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 12:41 ` Bernt Hansen
  2010-07-05 13:19   ` Tassilo Horn
@ 2010-07-05 20:30   ` Tassilo Horn
  2010-07-05 21:12     ` Bernt Hansen
  1 sibling, 1 reply; 10+ messages in thread
From: Tassilo Horn @ 2010-07-05 20:30 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Bernt Hansen

Hi again, Bernt!

I did some debugging.  The reason that the repeating events are not
shown is that `org-agenda-get-timestamps' doesn't return those repeater
events, because when it iterates over all timestamps of a file, the test
in the following `if' always returns t and so we are skipping.

--8<---------------cut here---------------start------------->8---
  (catch :skip
    (and (org-at-date-range-p) (throw :skip nil))
    (org-agenda-skip)
    (if (and (match-end 1)
         (not (= d1 (org-time-string-to-absolute
                 (match-string 1) d1 nil
                 org-agenda-repeating-timestamp-show-all))))
        (throw :skip nil))
--8<---------------cut here---------------end--------------->8---

This happens, because `org-time-string-to-absolute' returns the first
date (the literally written date), not the closest repeating date.

For example, for "<2010-06-28 Mon 22:00 +1w>" (last week's Monday) that
function returns 733951, although it should return 733958 (last week's
Monday + 7 days = today), I guess.

The underlined predicate looks suspicious to me:

--8<---------------cut here---------------start------------->8---
(defun org-time-string-to-absolute (s &optional daynr prefer show-all)
  "Convert a time stamp to an absolute day number.
If there is a specifyer for a cyclic time stamp, get the closest date to
DAYNR.
PREFER and SHOW-ALL are passed through to `org-closest-date'.
the variable date is bound by the calendar when this is called."
  (let ((today (calendar-absolute-from-gregorian (calendar-current-date))))
    (cond
     ((and daynr (string-match "\\`%%\\((.*)\\)" s))
      (if (org-diary-sexp-entry (match-string 1 s) "" date)
          daynr
        (+ daynr 1000)))
     ((and daynr (not (eq daynr today)) (string-match "\\+[0-9]+[dwmy]" s))
                 ^^^^^^^^^^^^^^^^^^^^^^
       (org-closest-date s (if (and (boundp 'daynr) (integerp daynr)) daynr
                 (time-to-days (current-time))) (match-string 0 s)
                 prefer show-all))
      (t (time-to-days (apply 'encode-time (org-parse-time-string s)))))))
--8<---------------cut here---------------end--------------->8---

Why shouldn't that case trigger when daynr is today?  In that case, we
don't even look at the timestamp s...

I deleted the whole underlined predicate, and then the agenda works
again for me.

Bye,
Tassilo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 20:30   ` Tassilo Horn
@ 2010-07-05 21:12     ` Bernt Hansen
  2010-07-05 21:16       ` Bernt Hansen
  2010-07-06  6:48       ` Tassilo Horn
  0 siblings, 2 replies; 10+ messages in thread
From: Bernt Hansen @ 2010-07-05 21:12 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: emacs-orgmode

Tassilo Horn <tassilo@member.fsf.org> writes:

> Hi again, Bernt!
>
> I did some debugging.

Thanks.  Sorry I've been tied up with work today.

> The reason that the repeating events are not shown is that
> `org-agenda-get-timestamps' doesn't return those repeater events,
> because when it iterates over all timestamps of a file, the test in
> the following `if' always returns t and so we are skipping.
>
> --8<---------------cut here---------------start------------->8---
>   (catch :skip
>     (and (org-at-date-range-p) (throw :skip nil))
>     (org-agenda-skip)
>     (if (and (match-end 1)
>          (not (= d1 (org-time-string-to-absolute
>                  (match-string 1) d1 nil
>                  org-agenda-repeating-timestamp-show-all))))
>         (throw :skip nil))
> --8<---------------cut here---------------end--------------->8---
>
> This happens, because `org-time-string-to-absolute' returns the first
> date (the literally written date), not the closest repeating date.
>
> For example, for "<2010-06-28 Mon 22:00 +1w>" (last week's Monday) that
> function returns 733951, although it should return 733958 (last week's
> Monday + 7 days = today), I guess.
>
> The underlined predicate looks suspicious to me:
>
> --8<---------------cut here---------------start------------->8---
> (defun org-time-string-to-absolute (s &optional daynr prefer show-all)
>   "Convert a time stamp to an absolute day number.
> If there is a specifyer for a cyclic time stamp, get the closest date to
> DAYNR.
> PREFER and SHOW-ALL are passed through to `org-closest-date'.
> the variable date is bound by the calendar when this is called."
>   (let ((today (calendar-absolute-from-gregorian (calendar-current-date))))
>     (cond
>      ((and daynr (string-match "\\`%%\\((.*)\\)" s))
>       (if (org-diary-sexp-entry (match-string 1 s) "" date)
>           daynr
>         (+ daynr 1000)))
>      ((and daynr (not (eq daynr today)) (string-match "\\+[0-9]+[dwmy]" s))
>                  ^^^^^^^^^^^^^^^^^^^^^^
>        (org-closest-date s (if (and (boundp 'daynr) (integerp daynr)) daynr
>                  (time-to-days (current-time))) (match-string 0 s)
>                  prefer show-all))
>       (t (time-to-days (apply 'encode-time (org-parse-time-string s)))))))
> --8<---------------cut here---------------end--------------->8---
>
> Why shouldn't that case trigger when daynr is today?  In that case, we
> don't even look at the timestamp s...

This change was my second attempt at fixing the scheduled display when a
weekly TODO entry is missed (ie it's over a week late already).  The
agenda display.  For the case where we're displaying the scheduled date
for today's agenda I wanted it to reflect how many days late the task is
instead of rolling over on the cyclic repeater.

I don't (yet) understand why your example works on my agenda but not
yours ...

Oh!  It's not that the future dates are missing it's the entry for
_today_ that is missing.  So yes my commit breaks this and I'll get it
reverted.

Thanks for reporting this issue!

Regards,
Bernt

>
> I deleted the whole underlined predicate, and then the agenda works
> again for me.
>
> Bye,
> Tassilo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 21:12     ` Bernt Hansen
@ 2010-07-05 21:16       ` Bernt Hansen
  2010-07-05 21:28         ` Carsten Dominik
  2010-07-06  6:48       ` Tassilo Horn
  1 sibling, 1 reply; 10+ messages in thread
From: Bernt Hansen @ 2010-07-05 21:16 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Tassilo Horn, emacs-orgmode

Bernt Hansen <bernt@norang.ca> writes:

> Oh!  It's not that the future dates are missing it's the entry for
> _today_ that is missing.  So yes my commit breaks this and I'll get it
> reverted.
>

Hi Carsten,

Please revert the following commit.  It's my second failed attempt at
fixing this issue.

I think I'll just leave it alone for now.  I'd rather have the agenda
display all entries as it does now than miss cyclic repeating entries
for today.

,----
| commit 516640aff96b627d8ad412f6cdb436535600aff0
| Author: Bernt Hansen <bernt@norang.ca>
| Date:   Wed Jun 23 02:40:16 2010 +0000
| 
|     Fix agenda display for late scheduled and deadline tasks
|     
|     * lisp/org.el (org-time-string-to-absolute): Ignore cyclic repeater
|     when displaying items on todays agenda date.
|     
|     Ignore the cyclic repeater when displaying items on today's agenda
|     date.  If you have a weekly task and miss the date the agenda view
|     will show more than a week late now instead of resetting on the
|     cyclic repeating date.  This makes it much more obvious when you
|     missed a repeating task after the repeater.
`----

Thanks,
Bernt

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 21:16       ` Bernt Hansen
@ 2010-07-05 21:28         ` Carsten Dominik
  0 siblings, 0 replies; 10+ messages in thread
From: Carsten Dominik @ 2010-07-05 21:28 UTC (permalink / raw)
  To: Bernt Hansen; +Cc: Carsten Dominik, emacs-orgmode, Tassilo Horn

Hi Bernt,

thanks, I have reverted the commit.  Too bad it is not working.

- Carsten


On Jul 5, 2010, at 11:16 PM, Bernt Hansen wrote:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> Oh!  It's not that the future dates are missing it's the entry for
>> _today_ that is missing.  So yes my commit breaks this and I'll get  
>> it
>> reverted.
>>
>
> Hi Carsten,
>
> Please revert the following commit.  It's my second failed attempt at
> fixing this issue.
>
> I think I'll just leave it alone for now.  I'd rather have the agenda
> display all entries as it does now than miss cyclic repeating entries
> for today.
>
> ,----
> | commit 516640aff96b627d8ad412f6cdb436535600aff0
> | Author: Bernt Hansen <bernt@norang.ca>
> | Date:   Wed Jun 23 02:40:16 2010 +0000
> |
> |     Fix agenda display for late scheduled and deadline tasks
> |
> |     * lisp/org.el (org-time-string-to-absolute): Ignore cyclic  
> repeater
> |     when displaying items on todays agenda date.
> |
> |     Ignore the cyclic repeater when displaying items on today's  
> agenda
> |     date.  If you have a weekly task and miss the date the agenda  
> view
> |     will show more than a week late now instead of resetting on the
> |     cyclic repeating date.  This makes it much more obvious when you
> |     missed a repeating task after the repeater.
> `----
>
> Thanks,
> Bernt

- Carsten

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)]
  2010-07-05 21:12     ` Bernt Hansen
  2010-07-05 21:16       ` Bernt Hansen
@ 2010-07-06  6:48       ` Tassilo Horn
  1 sibling, 0 replies; 10+ messages in thread
From: Tassilo Horn @ 2010-07-06  6:48 UTC (permalink / raw)
  To: Bernt Hansen; +Cc: emacs-orgmode

On Monday 05 July 2010 23:12:46 Bernt Hansen wrote:

Hi Bernt,

> > I did some debugging.
> 
> Thanks.  Sorry I've been tied up with work today.

No problem.  I had some time (and fun) with the debugging.  That was the
first time I dug into the depth of org's internals. ;-)

> Oh!  It's not that the future dates are missing it's the entry for
> _today_ that is missing.

Ups, I should have been a bit more clear on that.  :-)

Anyway, since Carsten reverted that commit, the agenda works again.

Bye,
Tassilo

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2010-07-06  6:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-05 10:28 Bug: Items with repeating timestamps don't appear in the agenda [6.36trans (release_6.36.509.g9e9b)] Tassilo Horn
2010-07-05 12:41 ` Bernt Hansen
2010-07-05 13:19   ` Tassilo Horn
2010-07-05 17:55     ` Tassilo Horn
2010-07-05 19:43       ` Bernt Hansen
2010-07-05 20:30   ` Tassilo Horn
2010-07-05 21:12     ` Bernt Hansen
2010-07-05 21:16       ` Bernt Hansen
2010-07-05 21:28         ` Carsten Dominik
2010-07-06  6:48       ` Tassilo Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).