emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-agenda: Fix category string for agenda
@ 2010-12-02 19:37 Matt Lundin
  2010-12-03  8:14 ` [Accepted] " Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Lundin @ 2010-12-02 19:37 UTC (permalink / raw)
  To: Org Mode

* lisp/org-agenda.el: (org-format-agenda-item) The value of
org-category is not converted to a string unless it is defined.

This fixes commit 3061c7083d8caa849cf2d3f2f53b8b71d45dd6de, which
resulted in org-format-agenda-item always returning the symbol-name for
org-category even if it was not defined. I.e., in some instances,
org-format-agenda-item returned the string "nil", thus bypassing the
buffer-file-name method of deriving the category.
---
 lisp/org-agenda.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 48856c9..c339f60 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5097,7 +5097,7 @@ Any match of REMOVE-RE will be removed from TXT."
     (let* ((category (or category
 			 (if (stringp org-category)
 			     org-category
-			   (symbol-name org-category))
+			   (and org-category (symbol-name org-category)))
 			 (if buffer-file-name
 			     (file-name-sans-extension
 			      (file-name-nondirectory buffer-file-name))
-- 
1.7.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Accepted] org-agenda: Fix category string for agenda
  2010-12-02 19:37 [PATCH] org-agenda: Fix category string for agenda Matt Lundin
@ 2010-12-03  8:14 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-12-03  8:14 UTC (permalink / raw)
  To: emacs-orgmode

Patch 431 (http://patchwork.newartisans.com/patch/431/) is now "Accepted".

Maintainer comment: Thanks for the perfect commit message.  One less I need to tweak.

This relates to the following submission:

http://mid.gmane.org/%3C87d3pkvtz8.fsf%40fastmail.fm%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] org-agenda: Fix category string for agenda
> Date: Fri, 03 Dec 2010 00:37:54 -0000
> From: Matt Lundin <mdl@imapmail.org>
> X-Patchwork-Id: 431
> Message-Id: <87d3pkvtz8.fsf@fastmail.fm>
> To: Org Mode <emacs-orgmode@gnu.org>
> 
> * lisp/org-agenda.el: (org-format-agenda-item) The value of
> org-category is not converted to a string unless it is defined.
> 
> This fixes commit 3061c7083d8caa849cf2d3f2f53b8b71d45dd6de, which
> resulted in org-format-agenda-item always returning the symbol-name for
> org-category even if it was not defined. I.e., in some instances,
> org-format-agenda-item returned the string "nil", thus bypassing the
> buffer-file-name method of deriving the category.
> 
> ---
> lisp/org-agenda.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 48856c9..c339f60 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5097,7 +5097,7 @@ Any match of REMOVE-RE will be removed from TXT."
>      (let* ((category (or category
>  			 (if (stringp org-category)
>  			     org-category
> -			   (symbol-name org-category))
> +			   (and org-category (symbol-name org-category)))
>  			 (if buffer-file-name
>  			     (file-name-sans-extension
>  			      (file-name-nondirectory buffer-file-name))
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-03  8:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-02 19:37 [PATCH] org-agenda: Fix category string for agenda Matt Lundin
2010-12-03  8:14 ` [Accepted] " Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).