emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Anders Waldenborg <anders@0x63.nu>
Cc: emacs-orgmode@gnu.org
Subject: Re: PATCH Make org-open-at-point only ask once
Date: Mon, 29 Aug 2011 11:36:19 +0200	[thread overview]
Message-ID: <87d3folfu4.fsf@gmail.com> (raw)
In-Reply-To: <20110829092146.GT5700@0x63.nu> (Anders Waldenborg's message of "Mon, 29 Aug 2011 11:21:46 +0200")

Anders Waldenborg <anders@0x63.nu> writes:

> But for org links, I'm not 100% sure - consider this org-file:
>
> * Notes
> * Some topic
> [[Notes]]
> ** Notes
>
> If buffer is widen, the link goes to the toplevel header, but if I
> narrow to "Some topic" the link suddenly starts going to the
> subheader.

And I think that totally makes sense. If the user bothered narrowing
buffer to a sub-tree, he probably wants to focus on the Notes relative to
that sub-tree.

Now, you're right, that search behaviour won't be consistent as long as
it will rely on narrowing.

Maybe we should define a consistent link search: ignore the narrowing
but first search in current sub-tree, if that fails (any error, I guess)
search in current tree and if that one fails too, search in the whole
buffer.

> Thanks for the review, I'll look into it soon.

Np.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2011-08-29  9:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 20:05 PATCH Make org-open-at-point only ask once Anders Waldenborg
2011-08-29  7:14 ` Nicolas Goaziou
2011-08-29  9:21   ` Anders Waldenborg
2011-08-29  9:36     ` Nicolas Goaziou [this message]
2011-08-29 10:53       ` Anders Waldenborg
2011-08-29 11:25         ` Nicolas Goaziou
2011-10-06  8:00 ` Carsten Dominik
2011-10-06  8:43   ` Anders Waldenborg
2011-10-06  8:54     ` Carsten Dominik
2011-10-06  9:51       ` Anders Waldenborg
2011-10-06  9:57         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d3folfu4.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=anders@0x63.nu \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).