From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: [test] Mark tests with missing dependencies as "expected to fail" Date: Tue, 22 Nov 2011 07:10:01 +0100 Message-ID: <87d3ck8z7q.wl%dmaus@ictsoc.de> References: <87fwiqnclu.wl%dmaus@ictsoc.de> <87fwiq2rsl.fsf@gmail.com> <87zkg0ov13.wl%dmaus@ictsoc.de> <8762inzunr.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Tue_Nov_22_07:10:01_2011-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:54726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSjYX-00015T-CP for emacs-orgmode@gnu.org; Tue, 22 Nov 2011 01:10:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSjYW-0001II-0I for emacs-orgmode@gnu.org; Tue, 22 Nov 2011 01:10:09 -0500 Received: from app1a.xlhost.de ([213.202.242.161]:34096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSjYV-0001GA-PP for emacs-orgmode@gnu.org; Tue, 22 Nov 2011 01:10:07 -0500 In-Reply-To: <8762inzunr.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: David Maus , emacs-orgmode@gnu.org --pgp-sign-Multipart_Tue_Nov_22_07:10:01_2011-1 Content-Type: text/plain; charset=US-ASCII At Sun, 13 Nov 2011 12:31:20 -0700, Eric Schulte wrote: > > [1 ] > David Maus writes: > > > Hi Eric, > > > > At Tue, 18 Oct 2011 10:22:34 -0600, > > Eric Schulte wrote: > >> Hi David, > >> > >> I agree it would be preferable to note that not all tests are run when > >> dependencies are missing, although I don't think it is extremely > >> important. I think some version of the above would be worthwhile if it > >> could be done in a file-wide manner (as are the current dependency > >> checks) and wouldn't require duplicating the dependency check or > >> changing every test form individually. Perhaps a file-local-variable > >> could be used to expect failures for every form defined in the file? > > > > I tried the approach with a file-local variable but it didn't work > > out: A macro can be expanded at any time, i.e. looks like there is no > > way to obtain a reference to the buffer where the macro is defined at > > expansion time. > > > > But finally came up with this one: > > > > Nice macro, > > The only downside I see is the requirement to wrap every single deftest > form which (to me) is too much overhead for too little payoff. How > about the following which will register a failing test for each file of > tests not loaded due to missing dependencies. The macro operates not just on a single `ert-deftest' form, but all deftests in BODY. It kind-of works like a file local variable. The current solution does its job, too -- so there's no need to use this macro. Getting feedback about tests not run because of missing dependencies is all I every wanted. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Tue_Nov_22_07:10:01_2011-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAk7LPLkACgkQma24O1pEeOYNJwD+Nl1Bg9TeVfQj7EdhcSBBws1Q X4EcoN2kwvFTJ9XYP3cBAMR8YaGOF61oEWYVr3GLWVy6pkI3ZFX2jBZyciqVdJlG =mFyZ -----END PGP SIGNATURE----- --pgp-sign-Multipart_Tue_Nov_22_07:10:01_2011-1--