From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: [Bug] Regression w/ insert into tables in overwrite-mode Date: Sat, 25 Feb 2012 19:59:59 +0100 Message-ID: <87d392u4b4.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:44347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1Mr6-0000JK-Ec for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 14:00:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1Mqp-0000kc-TQ for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 14:00:19 -0500 Received: from plane.gmane.org ([80.91.229.3]:49288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1Mqp-0000kQ-MP for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 14:00:11 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S1Mqo-0006RA-0l for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 20:00:10 +0100 Received: from pd9eb32c0.dip.t-dialin.net ([217.235.50.192]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 25 Feb 2012 20:00:10 +0100 Received: from Stromeko by pd9eb32c0.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 25 Feb 2012 20:00:10 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Commit 00040e7 by David Maus has introduced a regression when inserting into org tables while overwrite mode is on. For each character inserted into a table cell, the cell (and the whole table row) gets shortened by one character. If the change can not be reverted, the deletion must not happen when overwrite mode is on, maybe through something like this: (if (not overwrite-mode) (delete-char -1)) Emacs24 actually does not have the doc string that admonishes not to use the function delete-backward-char in non-interactive mode, so the point of the commit may actually be moot (although neither the doc string of delete-char nor delete-backward char make much mention of overwrite mode). Interestingly, even though I am inside the table, org-self-insert-command gets called and not orgtbl-self-insert-command, so I can't really say if both changes would need to be fixed in the same way. Additionally, it appears that the implementation and the doc string for orgtbl-self-insert-command don't match, there doesn't seem to be any use of overwrite mode in its implementation. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Samples for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra