emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: [Bug] Regression w/ insert into tables in overwrite-mode
Date: Sat, 25 Feb 2012 19:59:59 +0100	[thread overview]
Message-ID: <87d392u4b4.fsf@Rainer.invalid> (raw)


Commit 00040e7 by David Maus has introduced a regression when inserting
into org tables while overwrite mode is on.  For each character inserted
into a table cell, the cell (and the whole table row) gets shortened by
one character.

If the change can not be reverted, the deletion must not
happen when overwrite mode is on, maybe through something like this:

      (if (not overwrite-mode) (delete-char -1))

Emacs24 actually does not have the doc string that admonishes not to use
the function delete-backward-char in non-interactive mode, so the point
of the commit may actually be moot (although neither the doc string of
delete-char nor delete-backward char make much mention of overwrite
mode).  Interestingly, even though I am inside the table,
org-self-insert-command gets called and not orgtbl-self-insert-command,
so I can't really say if both changes would need to be fixed in the same
way.

Additionally, it appears that the implementation and the doc string for
orgtbl-self-insert-command don't match, there doesn't seem to be any use
of overwrite mode in its implementation.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

             reply	other threads:[~2012-02-25 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25 18:59 Achim Gratz [this message]
2012-02-27 19:27 ` [Bug] Regression w/ insert into tables in overwrite-mode Achim Gratz
2012-03-27 21:53   ` Bastien
2012-03-05 19:25 ` Achim Gratz
2012-03-16 18:15 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d392u4b4.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).