emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: emacs-orgmode@gnu.org
Subject: Re: bug#11249: 24.1.50; Overlay with face property causes	calendar buffer to scroll
Date: Thu, 26 Apr 2012 15:43:26 +0200	[thread overview]
Message-ID: <87d36uip6p.fsf@gnu.org> (raw)
In-Reply-To: <20120426131911.GA3469@c3po> (Toby Cubitt's message of "Thu, 26 Apr 2012 15:19:11 +0200")

Toby Cubitt <tsc25@cantab.net> writes:

> On Thu, Apr 26, 2012 at 10:59:50AM +0200, Bastien wrote:
>> Hi Matt,
>> 
>> Matt Lundin <mdl@imapmail.org> writes:
>> 
>> > Note: It seems that adding the optional argument KEEPDATE is necessary
>> > for parsing to work. With the following line instead of the one above
>> > org-read-date works as expected:
>> >
>> >  	  (org-eval-in-calendar '(setq cursor-type nil) t)
>> 
>> that's right -- I pushed this fix to master.  Thanks for reporting this
>> and for detailing the solution!
>
> Thanks for the fix!
>
> What exactly does KEEPDATE argument do? The `org-eval-in-calendar'
> docstring doesn't mention it anywhere, which is probably why I missed it
> in my patch. Looking at the code, it seems that the part about storing
> the cursor date in org-ans2 only happens for a non-nil KEEPDATE?

When keepdate is nil (which is the default), org-ans2 is updated wrt the
cursor date. At the time we set the cursor-type, we don't want to override 
org-ans2, we want to stick to the value already set.

> I'd post an update to improve the `org-eval-in-calendar' docstring, but I
> don't feel like I really understand what the KEEPDATE argument does well
> enough.

I just fixed the docstring like this:

  "Eval FORM in the calendar window and return to current window.
When KEEPDATE is non-nil, update `org-ans2' from the cursor date,
otherwise stick to the current value of `org-ans2'."

Thanks!

-- 
 Bastien

     prev parent reply	other threads:[~2012-04-26 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <83zkaczq1v.fsf@gnu.org>
2012-04-15 21:04 ` bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll Toby Cubitt
2012-04-16  2:50   ` Eli Zaretskii
2012-04-16 13:41     ` Toby Cubitt
2012-04-20 11:57       ` Bastien
2012-04-21 19:34         ` Toby Cubitt
2012-04-22  6:46           ` Bastien
2012-04-22 10:05             ` Toby Cubitt
2012-04-25 21:30             ` Matt Lundin
2012-04-25 23:10               ` Matt Lundin
2012-04-26  8:59                 ` Bastien
2012-04-26 13:19                   ` Toby Cubitt
2012-04-26 13:43                     ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d36uip6p.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).