emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Florian Beck <fb@miszellen.de>
To: Bastien <bzg@altern.org>
Cc: Florian Beck <fb@miszellen.de>, emacs-orgmode@gnu.org
Subject: Re: Unescape :help-echo in links
Date: Thu, 21 Mar 2013 21:22:34 +0100	[thread overview]
Message-ID: <87d2ussdth.fsf@sophokles.streitblatt.de> (raw)
In-Reply-To: <87y5dh3ccs.fsf@bzg.ath.cx> (Bastien's message of "Thu, 21 Mar 2013 00:01:07 +0100")

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Bastien <bzg@altern.org> writes:

> Can you resend it as a proper patch with a changelog?

Like this?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org.el-org-activate-bracket-links-remove-escape.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]

From ca9c612208a2528a27b648973cfbf6e8d0801f94 Mon Sep 17 00:00:00 2001
From: Florian Beck <fb@miszellen.de>
Date: Thu, 21 Mar 2013 21:15:50 +0100
Subject: [PATCH] Unescape :help-echo for links

* lisp/org.el (org-activate-bracket-links): remove escapes
 from help string

TINYCHANGE

---
 lisp/org.el |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 7aac63b..3fbd549 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5806,10 +5806,7 @@ by a #."
   (if (and (re-search-forward org-bracket-link-regexp limit t)
 	   (not (org-in-src-block-p)))
       (let* ((hl (org-match-string-no-properties 1))
-	     (help (concat "LINK: " hl))
-	     ;; FIXME: Above we should remove the escapes.  But that
-	     ;; requires another match, protecting match data, a lot
-	     ;; of overhead for font-lock.
+	     (help (concat "LINK: " (save-match-data (org-link-unescape hl))))
 	     (ip (org-maybe-intangible
 		  (list 'invisible 'org-link
 			'keymap org-mouse-map 'mouse-face 'highlight
-- 
1.7.10.4


[-- Attachment #3: Type: text/plain, Size: 19 bytes --]



-- 
Florian Beck

  reply	other threads:[~2013-03-21 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 19:27 Unescape :help-echo in links Florian Beck
2013-03-20 23:01 ` Bastien
2013-03-21 20:22   ` Florian Beck [this message]
2013-04-08 15:55     ` Bastien
2013-04-14 10:20     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2ussdth.fsf@sophokles.streitblatt.de \
    --to=fb@miszellen.de \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).