emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
To: emacs-orgmode@gnu.org
Subject: [PATCH] * lisp/org.el (org-scan-tags): do not impose a value of case-fold-search on the user
Date: Fri, 21 Jun 2013 10:48:33 +0200	[thread overview]
Message-ID: <87d2rfsvby.fsf@yahoo.fr> (raw)

Hello,

when using org-contacts,

(let ((filename (make-temp-file "contacts" nil ".org")))
  (with-temp-file filename
    (insert "* Eva Luator\n:PROPERTIES:\n:EMAIL: eva@gmail.com.invalid\n:END:\n"))
  (let ((org-contacts-files (list filename)))
    (org-contacts "eva luator")))

doesn't list Eva Luator in the Contacts buffer, although
case-fold-search is set to t for me. I think it's an org-mode bug in
fact ; I suggest the following :

From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Date: Wed, 5 Jun 2013 15:02:37 +0200

---
 lisp/org.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 97773a0..da3e2f0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -13807,7 +13807,6 @@ headlines matching this string."
 			      (abbreviate-file-name
 			       (or (buffer-file-name (buffer-base-buffer))
 				   (buffer-name (buffer-base-buffer)))))))
-	 (case-fold-search nil)
 	 (org-map-continue-from nil)
          lspos tags tags-list
 	 (tags-alist (list (cons 0 org-file-tags)))
@@ -13820,7 +13819,8 @@ headlines matching this string."
       (when (eq action 'sparse-tree)
 	(org-overview)
 	(org-remove-occur-highlights))
-      (while (re-search-forward re nil t)
+      (while (let (case-fold-search)
+	       (re-search-forward re nil t))
 	(setq org-map-continue-from nil)
 	(catch :skip
 	  (setq todo (if (match-end 1) (org-match-string-no-properties 2))
-- 
1.8.1.5

             reply	other threads:[~2013-06-21  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  8:48 Nicolas Richard [this message]
2013-06-27 14:35 ` [PATCH] * lisp/org.el (org-scan-tags): do not impose a value of case-fold-search on the user Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2rfsvby.fsf@yahoo.fr \
    --to=theonewiththeevillook@yahoo.fr \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).