From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: Bug? org-set-tags never uses ido
Date: Fri, 01 Nov 2013 09:33:50 +0800
Message-ID: <87d2mknbwh.fsf@ericabrahamsen.net>
References: <527287AB.10707@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vc3bV-0008UM-D1
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 21:32:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vc3bO-0003i0-2T
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 21:32:49 -0400
Received: from plane.gmane.org ([80.91.229.3]:59016)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vc3bN-0003g8-QY
	for emacs-orgmode@gnu.org; Thu, 31 Oct 2013 21:32:41 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Vc3bL-0003Fp-Be
	for emacs-orgmode@gnu.org; Fri, 01 Nov 2013 02:32:39 +0100
Received: from 114.248.26.151 ([114.248.26.151])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Fri, 01 Nov 2013 02:32:39 +0100
Received: from eric by 114.248.26.151 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Fri, 01 Nov 2013 02:32:39 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Anders Johansson <mejlaandersj@gmail.com> writes:

> Greetings,
> I want to use ido everywhere and wanted to know why this doesn't seem
> to work for setting org-mode tags (it never has for me).
>
> Using edebug to step through the call to org-icompleting-read which
> org-set-tags does I can see that it never gets to using ido since the
> last condition below is false:
> org.el:10147-10150 (package repository version 20131028):
>    (if (and org-completion-use-ido
>         (fboundp 'ido-completing-read)
>         (boundp 'ido-mode) ido-mode
>         (listp (second args)))
>
> This is not strange, since org-icompleting-read is called like this in
> org-set-tags:
>
> org.el:14519-14521
>                (org-icompleting-read "Tags: "
>                          'org-tags-completion-function
>                          nil nil current 'org-tags-history))))))

Hmm, shouldn't that 'org-tags-completion-function be replaced with
org-last-tags-completion-table? A quick test shows that works, and from
glancing at the code it seems like org-last-tags-completion-table should
hold the proper assortment of tags...

E

>
> ido apparently needs a list of possible completions, not a single symbol.
>
> I don't understand much more of this really.
> Is it a bug? Have I misunderstood something?
>
> Greetings,
> Anders Johansson