emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Oleh <ohwoeowho@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] lisp/org.el (org-open-at-point): prioritize link
Date: Thu, 27 Feb 2014 23:40:00 +0100	[thread overview]
Message-ID: <87d2i8qiwv.fsf@gmail.com> (raw)
In-Reply-To: <CAA01p3pNBFfdTh870gR7J+xchzFiPS11+54BW67S7t0SVDbpGw@mail.gmail.com> (Oleh's message of "Thu, 27 Feb 2014 14:28:57 +0100")

Hello,

Oleh <ohwoeowho@gmail.com> writes:

> Can someone check this patch and commit it.
> It allows to open links that look like this:
>
>     [[id:164552ee-b92d-4af6-9570-60d039876fac][=foobar=]]

I applied a generalization of your patch. Thank you.

While I'm at it, here are a few comments.

> +	   (parent (plist-get (cadr context) :parent))

This is too low level. It should really be:

  (parent (org-element-property :parent context))

> +	   (context (if (eq (car parent) 'link) parent context))

Same here. The preferred syntax is:

  (context (if (eq (org-element-type parent) 'link) parent context))


Regards,

-- 
Nicolas Goaziou

     prev parent reply	other threads:[~2014-02-27 22:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 13:28 [PATCH] lisp/org.el (org-open-at-point): prioritize link Oleh
2014-02-27 22:40 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2i8qiwv.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).