emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: org capture contexts not working?
Date: Sun, 20 Apr 2014 13:20:24 +0800	[thread overview]
Message-ID: <87d2gcwqp1.fsf@ericabrahamsen.net> (raw)

I've got this for three capture templates that should only work in Gnus:

(setq org-capture-templates-contexts
      '(("M" ((in-mode . "gnus-\\(summary\\|article\\)")))
	("P" ((in-mode . "gnus-\\(summary\\|article\\)")))
	("H" ((in-mode . "gnus-\\(summary\\|article\\)")))))

This worked for quite some time, but when I went back to use it again
today I found that these templates aren't filtered out in non-Gnus
settings. I tried stepping through the code of
`org-contextualize-validate-key' and think I've found the problem,
though I'll confess to a little confusion.

When that function checks the predicates (in-mode, not-in-file, etc), it
has this chunk for handling the not-in-file bit:

(if (and (eq (car rr) 'not-in-file)
         (buffer-file-name))
    (not (string-match (cdr rr) (buffer-file-name)))
  t)

This was slightly mis-aligned in the source file, leading me to believe
it's just a nesting error. As it is, any template which *isn't using*
the not-in-file predicate is going to flag as acceptable for the current
context. I think it should just be:

(when (and (eq (car rr) 'not-in-file)
	   (buffer-file-name))
  (not (string-match (cdr rr) (buffer-file-name))))

Testing indicates it works, am I missing anything? Pickaxe search for
the string "not-in-file" in git says the last relevant commit was two
years ago, so who knows what's going on...

Eric

next             reply	other threads:[~2014-04-20  5:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-20  5:20 Eric Abrahamsen [this message]
2014-04-20  6:44 ` org capture contexts not working? Bastien
2014-04-20  8:12   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2gcwqp1.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).