From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [RFC] [PATCH] ob-core.el: allow the auto-generation of output file names for src blocks. Date: Thu, 15 May 2014 23:28:52 -0400 Message-ID: <87d2fel7y4.fsf@gmail.com> References: <1398196476-4773-1-git-send-email-aaronecay@gmail.com> <87bnvt2h6r.fsf@bzg.ath.cx> <87d2g92au5.fsf@gmail.com> <8738h49u2g.fsf@gmail.com> <8761lugqyi.fsf@gmail.com> <87ha55a5tb.fsf@gmail.com> <87tx8wnje4.fsf@gmail.com> <87siocqmlo.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl8pV-0001oE-Eq for emacs-orgmode@gnu.org; Thu, 15 May 2014 23:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl8pM-0005JC-EZ for emacs-orgmode@gnu.org; Thu, 15 May 2014 23:29:05 -0400 Received: from mail-qc0-x22e.google.com ([2607:f8b0:400d:c01::22e]:57226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl8pM-0005J8-9C for emacs-orgmode@gnu.org; Thu, 15 May 2014 23:28:56 -0400 Received: by mail-qc0-f174.google.com with SMTP id x13so3322275qcv.5 for ; Thu, 15 May 2014 20:28:55 -0700 (PDT) In-Reply-To: <87siocqmlo.fsf@Rainer.invalid> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz , emacs-orgmode@gnu.org Hi Achim, 2014ko maiatzak 14an, Achim Gratz-ek idatzi zuen: > That breaks the tests for Octave and Maxima; since you're intentionally > not keeping backwards compatibility here this should be fixed in the > tests, I'd think. Fixed. (It actually required changes to the code, not the tests, since my commit made org-babel-graphical-output-file stricter). > > Also, I'd think you should be using "user-error" instead of error to > generate the messages. Good catch (especially since I recently pushed a patch changing some errors to user-errors *blush*). Fixed. Thanks, -- Aaron Ecay