From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus <rasmus@gmx.us>
Subject: Re: [bug, patch, ox] INCLUDE and footnotes
Date: Wed, 24 Dec 2014 18:54:02 +0100
Message-ID: <87d2799bnp.fsf@gmx.us>
References: <87h9x5hwso.fsf@gmx.us> <87oarcbppe.fsf@nicolasgoaziou.fr>
	<87fvcozfhf.fsf@gmx.us> <87h9x4bj33.fsf@nicolasgoaziou.fr>
	<87iohks4ne.fsf@gmx.us> <87d27rbvio.fsf@nicolasgoaziou.fr>
	<87bnnbhg2x.fsf@gmx.us> <878uifbjc7.fsf@nicolasgoaziou.fr>
	<87388j9qbv.fsf@gmx.us> <87y4q57t2i.fsf@nicolasgoaziou.fr>
	<87lhm4n9ky.fsf@pank.eu> <87mw6gyctg.fsf@nicolasgoaziou.fr>
	<87lhm01mj7.fsf@gmx.us> <87wq5kvt2g.fsf@nicolasgoaziou.fr>
	<8761d32759.fsf@gmx.us> <87h9wn4d8r.fsf@nicolasgoaziou.fr>
	<87vbl3z65i.fsf@gmx.us> <878uhz47t2.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1Y3q8Z-0000ym-9M
	for emacs-orgmode@gnu.org; Wed, 24 Dec 2014 12:54:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1Y3q8S-0000ZW-Mo
	for emacs-orgmode@gnu.org; Wed, 24 Dec 2014 12:54:19 -0500
Received: from mout.gmx.net ([212.227.15.19]:62151)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rasmus@gmx.us>) id 1Y3q8S-0000Xs-DR
	for emacs-orgmode@gnu.org; Wed, 24 Dec 2014 12:54:12 -0500
Received: from W530 ([89.186.183.135]) by mail.gmx.com (mrgmx003) with ESMTPSA
	(Nemesis) id 0MRFwV-1YSkSp2Ojv-00UYTi for <emacs-orgmode@gnu.org>;
	Wed, 24 Dec 2014 18:54:04 +0100
In-Reply-To: <878uhz47t2.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Mon, 22 Dec 2014 23:51:37 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> I think you can push once the issues above are fixed. Thank you for the
> work.

Pushed!

> However, this raises a question: why are we modifying definition at all?
> We are only interested in its new label, which we can get without
> modifying buffer (i.e. if definition is within range, modify it,
> otherwise, compute new label and store its definition).

I fixed this in the train today (going home).  I just committed it,
though, so I hope I didn't break org (the tests were running, though
before all of your re-factoring today which I just saw).

Please let me know if I did any git mistakes.  Somehow the time got skewed
up and it's behind some of your commits in cgit. . .

Cheers,
Rasmus

-- 
May the Force be with you