emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Yuri D Lensky <ydl@mit.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [Patch] Fix date-based sorting of tags and tags-todo agenda views
Date: Sat, 07 Feb 2015 22:14:19 +0100	[thread overview]
Message-ID: <87d25ltokq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1D119613313E504D8C7FDD06E9B6DD40C951ADE8@OC11expo28.exchange.mit.edu> (Yuri D. Lensky's message of "Sat, 7 Feb 2015 19:05:52 +0000")

Hello,

Yuri D Lensky <ydl@mit.edu> writes:

> An example to test this problem:
>
> Evaluate:
> (setq org-agenda-custom-commands
>       '(("t" "TEST" tags-todo "tag"
>          ((org-agenda-sorting-strategy '(deadline-up))))))
> then run the view. It will not be sorted properly before the patch,
> but will be after.

Thank you. It looks good.

> I would also recommend factoring the code that I added out into
> a separate function (as it also appears almost verbatim in
> org-agenda-get-todos), but I am not sure the conventions or desire for
> this.

I agree it would be good to do that refactoring. Do you want to take
care of it in the same patch?

> From c8a7211639d9c138a3b3dcb7e3ce7c85264580f1 Mon Sep 17 00:00:00 2001
> From: "Yuri D. Lensky" <ydl@ydl.cm>
> Date: Sat, 7 Feb 2015 13:37:46 -0500
> Subject: [PATCH] Fix timestamp-based sorting of tags-based entries in agenda
>
> * lisp/org.el (org-scan-tags): Fix agenda org tags scans to properly
>   add timestamp property, completely analogously to org-agenda-get-todos.
>
> Before this fix, timestamps were ignored when sorting agenda views of
> the 'tags' and 'tags-todo' types.

You need to add TINYCHANGE at the end of the commit message. If your
patch ends up being more than 20 lines long, you'll also need to sign
FSF assignment (if not already done). See

  http://orgmode.org/worg/org-contribute.html#unnumbered-2


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2015-02-07 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 19:05 [Patch] Fix date-based sorting of tags and tags-todo agenda views Yuri D Lensky
2015-02-07 21:14 ` Nicolas Goaziou [this message]
2015-02-08 18:54   ` Yuri D. Lensky
2015-02-08 20:18     ` Nicolas Goaziou
  -- strict thread matches above, loose matches on Subject: below --
2015-02-09  1:37 Yuri D. Lensky
2015-02-09 23:13 ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d25ltokq.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=ydl@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).