From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [PATCH v2 0/9] mail, clock and calc changes Date: Wed, 04 Nov 2015 11:36:03 +0000 Message-ID: <87d1vqvvx8.fsf@gmail.com> References: <1446581747-1960-1-git-send-email-oxij@oxij.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwML-0006fe-J6 for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:36:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtwMI-00064Q-CL for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:36:09 -0500 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:36711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwMI-00064M-6Z for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:36:06 -0500 Received: by wicfx6 with SMTP id fx6so87545546wic.1 for ; Wed, 04 Nov 2015 03:36:05 -0800 (PST) In-Reply-To: <1446581747-1960-1-git-send-email-oxij@oxij.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: Jan Malakhovski Hi Jan, Thanks for the patches! They look good to me. I sent a few minor comments about code style. I didn=E2=80=99t review the 8th patch (ob-calc:= add more API, documentation and examples so that it can be used in tables) because I didn=E2=80=99t feel familiar enough with the calc API to be usefu= l. Do you want somebody to apply the tinychange patches already? Or do you want to wait until your assignment is processed and apply them yourself? (IMO patch 4 could also be a TINYCHANGE, since it is only code movement with no actual changes). --=20 Aaron Ecay