From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Capture template file source variant support in Customize [8.3.4 (8.3.4-47-gaf853d-elpa @ /home/phil/.emacs.d/elpa/org-20160502/)] Date: Tue, 10 May 2016 23:21:12 +0200 Message-ID: <87d1otk3sn.fsf@saiph.selenimh> References: <87r3dehru8.fsf@quiz.hudson-it.ddns.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0F5o-0005nr-SD for emacs-orgmode@gnu.org; Tue, 10 May 2016 17:21:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0F5k-0002PE-62 for emacs-orgmode@gnu.org; Tue, 10 May 2016 17:21:24 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0F5j-0002P7-OP for emacs-orgmode@gnu.org; Tue, 10 May 2016 17:21:20 -0400 In-Reply-To: <87r3dehru8.fsf@quiz.hudson-it.ddns.net> (Phil Hudson's message of "Sat, 07 May 2016 15:21:03 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Phil Hudson Cc: emacs-orgmode@gnu.org Hello, Phil Hudson writes: > Expected: When using the Customize interface to create/edit an Org > capture template, we expect to be able to specify a file to write the > captured item into using (according to the documentation) any one of: > * a literal filename > * a function > * a variable > * a form > But the Customize UI supports only the first of these. The attached > patch adds Customize support for the other three variants, in the proper > order (increasing generality/decreasing specificity). > > Note that using Lisp to specify a capture template's target file using a > function, variable or sexp *does* work fine and as documented, except > that thereafter Customize fails to present the resulting variable > correctly; it reverts to showing the alist as one Lisp form. This patch > simply "catches up" the Customize UI with what Org can do and is > documented as doing. Sounds good. However, wouldn't it make sense to also add these types to other file related target locations, e.g., "File & Headline", "File & Outline path"... ? Also, could you provide a patch using `git format-patch'? Thank you. Regards, -- Nicolas Goaziou