emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Don March <don@ohspite.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make today's deadlines "close" without lead time
Date: Thu, 02 Jun 2016 10:12:06 +0200	[thread overview]
Message-ID: <87d1o09fhl.fsf@saiph.selenimh> (raw)
In-Reply-To: <CABSfPEqDgVC-OVCYFir5q7x9rSC5qY69xWRQJK=JVidEa_xMTQ@mail.gmail.com> (Don March's message of "Wed, 1 Jun 2016 01:57:55 -0400")

Hello,

Don March <don@ohspite.net> writes:

> This patch makes a very small change to the function that determines if a
> timestamp is close to the current day, which is used for showing/hiding items in
> agenda views.
>
> Under current behavior, a deadline of today is close only if it has some amount
> of lead time. If your date is 2016-06-01, the following statements evaluate to
> nil:
> #+BEGIN_SRC emacs-lisp
> (org-deadline-close "2016-06-01 Wed -0d") ;; but this is today!
> (org-deadline-close "2016-06-02 Wed -1d")
> #+END_SRC
>
> One effect of this is that if you set =org-agenda-todo-ignore-deadlines= to
> =far= and generate the TODO list agenda view (C-c a t), then items only appear
> if you are one day past the point at which they should appear. For example, the
> following item does not show up in my current TODO list:
> #+BEGIN_EXAMPLE
> * TODO due today, no lead time
> DEADLINE: <2016-06-01 -0d>
> #+END_EXAMPLE

Thank you for the patch.

Did you sign FSF papers? Otherwise, a TINYCHANGE cookie is needed at the
end of the commit message.

Also, would you mind providing a few tests for this function, in
"test-org.el"?

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2016-06-02  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  5:57 [PATCH] Make today's deadlines "close" without lead time Don March
2016-06-02  8:12 ` Nicolas Goaziou [this message]
2016-06-03  7:17   ` Don March
2016-06-04 19:30     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1o09fhl.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=don@ohspite.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).