emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Karl Voit <devnull@Karl-Voit.at>
Cc: Karl Voit <news1142@Karl-Voit.at>, emacs-orgmode@gnu.org
Subject: Re: Bug: org-clone-subtree-with-time-shift not asking for time-shift
Date: Tue, 17 Jan 2017 09:54:54 +0100	[thread overview]
Message-ID: <87d1fm3w2p.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <2017-01-16T23-27-40@devnull.Karl-Voit.at> (Karl Voit's message of "Mon, 16 Jan 2017 23:30:14 +0100")

Hello,

Karl Voit <devnull@Karl-Voit.at> writes:

> * Kyle Meyer <kyle@kyleam.com> wrote:
>>
>> Thanks.  The additional check looks good, as it replaces an error with a
>> more appropriate user-error and gives an error message that is a bit
>> more specific.
>>
>> However, the re-positioning of the org-back-to-heading call seems
>> problematic because the call is now wrapped in a save-excursion, but the
>> downstream code expects point to be at the beginning of the heading.
>>
>> When I call org-clone-subtree-with-time-shift with point at the end of
>>
>>     *** heading <2017-02-28 Wed>
>> I get the following error:
>>     Debugger entered--Lisp error: (error "Before first headline at position 1 in buffer  *temp*")
> [...]
>> I think this is because beg isn't set to the beginning of the heading.
>>
>> But given Karl's recent email saying that the changes in maint fixed his
>> test cases, maybe I'm missing something ...
>
> I have to excuse myself: I tested not good enough: I only tested my
> cases for being asked for the time-shift and not finished executing
> the cases.
>
> You're right, I can confirm your issue. I get "Before first headline
> at position 1 in buffer  *temp*" as well.

Fixed (hopefully) this time.

Thank you.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2017-01-17  8:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 11:48 Bug: org-clone-subtree-with-time-shift not asking for time-shift Karl Voit
2017-01-16 14:50 ` Karl Voit
2017-01-16 17:56 ` Kyle Meyer
2017-01-16 21:31   ` Nicolas Goaziou
2017-01-16 22:07     ` Bug: org-clone-subtree-with-time-shift not asking for time-shift (FIXED) Karl Voit
2017-01-16 22:23     ` Bug: org-clone-subtree-with-time-shift not asking for time-shift Kyle Meyer
2017-01-16 22:30       ` Karl Voit
2017-01-17  8:54         ` Nicolas Goaziou [this message]
2017-01-18  2:42           ` Kyle Meyer
2017-01-18 11:11             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1fm3w2p.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=devnull@Karl-Voit.at \
    --cc=emacs-orgmode@gnu.org \
    --cc=news1142@Karl-Voit.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).