From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: Behavior of `org-show-entry' Date: Sun, 05 Feb 2017 17:03:11 -0500 Message-ID: <87d1ew5m8w.fsf@kyleam.com> References: <87lgtk8kja.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caUtx-0003IR-9U for emacs-orgmode@gnu.org; Sun, 05 Feb 2017 17:03:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caUtu-0003zX-2A for emacs-orgmode@gnu.org; Sun, 05 Feb 2017 17:03:17 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:54522 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caUtt-0003zK-ST for emacs-orgmode@gnu.org; Sun, 05 Feb 2017 17:03:14 -0500 In-Reply-To: <87lgtk8kja.fsf@ericabrahamsen.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Eric Abrahamsen , emacs-orgmode@gnu.org Eric Abrahamsen writes: > I do a lot of my Org navigation with `helm-org-in-buffer-headings' and > `helm-org-agenda-files-headings', which prompt you for an org heading, > then take you there. > > I'm always annoyed that, once you're at the heading, it leaves it in > a half-open state where you can see the immediate text of the target > entry, but all of its child entries are replaced by an ellipses. > > * Target Heading > Drawers and text > ... # ellipses instead of child headings > * Next Heading > > You then have to hit twice to see the children. > > The helm commands end by calling `org-show-entry', which first does > this: > > (outline-flag-region > (max (point-min) (1- (point))) > (save-excursion > (if (re-search-forward > (concat "[\r\n]\\(" org-outline-regexp "\\)") nil t) > (match-beginning 1) > (point-max))) > nil) > > Which leaves the heading in the state described above, and then does > this: > > (org-cycle-hide-drawers 'children) > > Which has no effect. > > I'm not really sure what the purpose of `outline-flag-region' is, but > I'm pretty sure this isn't the desired effect. Based on how org-show-entry calls it, outline-flag-region shows the text from the current heading to the next. So it seems to behave as documented: "[s]how the body directly following this heading". > The call to `org-cycle-hide-drawers' should reveal children, isn't > that right? The purpose isn't to reveal the child headings (I don't understand why the argument is called "children"), but to hide the drawers. Without the org-cycle-hide-drawers call, org-show-entry would expand * TODO blah... to * TODO blah SCHEDULED: <2017-02-12 Sun .+1w> :PROPERTIES: :LAST_REPEAT: [2017-02-05 Sun 16:31] :END: :LOGBOOK: - State "DONE" from "TODO" [2017-02-05 Sun 16:31] :END: instead of * TODO blah SCHEDULED: <2017-02-12 Sun .+1w> :PROPERTIES:... :LOGBOOK:... > Which part of this should be tweaked to achieve the desired effect? Perhaps helm could call org-show-children after it calls org-show-entry. -- Kyle