From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] don't always restore previous window configuration? Date: Sun, 25 Nov 2018 10:02:09 +0100 Message-ID: <87d0qt1qem.fsf@nicolasgoaziou.fr> References: <87zhu0nw36.fsf@gmail.com> <87tvk62199.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQqIy-0004qF-9V for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 04:02:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQqIv-0008Gw-2O for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 04:02:16 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33831) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gQqIu-0008Bv-Qn for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 04:02:12 -0500 In-Reply-To: (Matt Price's message of "Sat, 24 Nov 2018 10:24:23 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Matt Price Cc: Org Mode Hello, Matt Price writes: > Then I'm sorry for the noise (and also for this aside!). Magit, or git, or > some other tool was doing something quite strange and disturbing, and I am > now seeing these remotes in my repo: > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (fetch) > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (push) > origin https://code.orgmode.org/bzg/org-mode.git (fetch) > origin https://code.orgmode.org/bzg/org-mode.git (push) > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (fetch) > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (push) My bad. It seems "test-org-annex.el" messes with "git init". Since I don't have git-annex command, these tests are usually skipped, so I hadn't noticed. > I'm not sure. Until now only Eric and I had commented on this feature. I > will say that I will probably never go back to the old behavior, but maybe > there are people who prefer it. I believe there are 6 possible options for > org-src-window-setup (though only 5 are listed in the defcustom definition, > I think that org-src-switch-to-buffer also recognizes 'silently). It may be > that some of those options only make sense if the window config is restored > after closing the src buffer. > > ~org-src--saved-window-config~ is only used in this function, so instead of > adding a new variable we could just get rid of an old one :-). IMO, the only value for `org-src-window-setup' where it might be meaningful to preserve windows excursion is `reorganize-frame', since it can disturb a lot the configuration used before editing the block. However, the docstring disagrees: "When exiting the edit buffer, return to one window." Therefore, I suggest to simply do not restore previous configuration in Org 9.3, and document it in incompatible changes. It will leave time to test it and complain if something is not right. WDYT? Regards, -- Nicolas Goaziou