From: "Pierre Téchoueyres" <pierre.techoueyres@free.fr>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Possible bug in org-protocol
Date: Thu, 07 Mar 2019 23:48:12 +0100 [thread overview]
Message-ID: <87d0n29u8j.fsf@killashandra.ballybran.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]
Hello Org developers,
I'm facing an unexpected behaviour since some days :
When I want to record some link from web sites using Org Capture extension
(https://github.com/sprig/org-capture-extension) for Firefox all my text
and links are encoded like urls.
It's look like the commit #cc7c4a673 removed some url decoding when
the org-protocol url is processed.
See bellow the steps to reproduce :
1) define some templates for org-protocol, mine are bellow
#+begin_src elisp
(setq org-capture-templates '(("L" "Protocol Link" entry (file+olp ,inbox "Web")
,(concat "* %:description :@website:\n"
" Captured On: %a, %U\n"
" %?\n\n"))
("p" "Protocol Selection" entry (file+olp ,inbox "Web")
,(concat "* %:description :@website:\n"
" Source: %a, %U\n"
" #+begin_quote\n%i\n #+end_quote\n"
" %?\n\n"))))
#+end_src
2) use emacsclient to trigger org-protocol like this
#+begin_src sh
emacsclient -n "org-protocol://capture?template=p&url=https%3A%2F%2Fgithub.com%2FCruiserX%2Fsha256_plsql&title=CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.&body=SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.%20"
#+end_src
the resulting buffer is :
#+begin_example
** CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g. :@website:
Source: [[https%253A%252F%252Fgithub.com%252FCruiserX%252Fsha256_plsql][CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.]], [2019-03-07 jeu. 23:36]
#+begin_quote
SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.%20
#+end_quote
#+end_example
I think that one possible fix could be to rollback one part of the git commit #cc7c4a673 like
in the patch bellow.
What do you think ?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix org-protocol unescape --]
[-- Type: text/x-patch, Size: 488 bytes --]
diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index f3e7281ee..d9fdef00e 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -381,7 +381,7 @@ If INFO is already a property list, return it unchanged."
(while data
(setq result
(append result
- (list (pop data) (pop data)))))
+ (list (pop data) (org-link-unescape (pop data))))))
result)
(let ((data (org-protocol-split-data info t org-protocol-data-separator)))
(if default-order
[-- Attachment #3: Type: text/plain, Size: 9 bytes --]
Pierre.
next reply other threads:[~2019-03-07 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:48 Pierre Téchoueyres [this message]
2019-03-08 8:11 ` [PATCH] Possible bug in org-protocol Nicolas Goaziou
2019-03-08 18:25 ` Pierre Téchoueyres
2019-03-09 10:14 ` Nicolas Goaziou
2019-03-09 13:14 ` Pierre Téchoueyres
2019-03-10 10:10 ` Nicolas Goaziou
2019-03-10 16:57 ` Pierre Téchoueyres
2019-03-10 17:23 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0n29u8j.fsf@killashandra.ballybran.fr \
--to=pierre.techoueyres@free.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).