emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Joaquín Aguirrezabalaga" <kinote@kinote.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix behaviour of ":dir" when ":mkdirp" is not defined
Date: Thu, 25 Apr 2019 10:39:02 +0200	[thread overview]
Message-ID: <87d0laqy1l.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878svyobcj.fsf@loge.kinote.org> ("Joaquín Aguirrezabalaga"'s message of "Thu, 25 Apr 2019 08:19:56 +0200")

Hello,

Joaquín Aguirrezabalaga <kinote@kinote.org> writes:

> Hello,
>
> I think the behaviour of ":dir" is broken since commit 8b5941330
> (ob-core: Make :mkdirp work for :dir too). It only works now if
> ":mkdirp" is defined.
>
> If I execute the following:
>
>   #+begin_src elisp :dir /tmp/some-test-dir
>   default-directory
>   #+end_src
>
>
> Instead of the expected "/tmp/some-test-dir" returned value, I get my
> current directory.
>
> Only add ":mkdirp t":
>
>   #+begin_src elisp :dir /tmp/some-test-dir :mkdirp t
>   default-directory
>   #+end_src
>
> do I get the expected result.
>
> Please find attached my proposal for fixing the issue.

Applied, with a slight refactoring to use `cond' instead of `or' + `if'.

I added TINYCHANGE at the end of the commit message since I don't know
if you signed FSF papers already.

Thank you.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-04-25  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25  6:19 [PATCH] Fix behaviour of ":dir" when ":mkdirp" is not defined Joaquín Aguirrezabalaga
2019-04-25  8:39 ` Nicolas Goaziou [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-04-24 10:43 Joaquín Aguirrezabalaga
2019-04-28 11:47 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0laqy1l.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kinote@kinote.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).