From: Tim Cross <theophilusx@gmail.com>
To: emacs-orgmode@gnu.org
Cc: "Doyley, Marvin M." <m.doyley@rochester.edu>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Issue with internal links
Date: Sat, 10 Aug 2019 12:03:32 +1000 [thread overview]
Message-ID: <87d0hdojyj.fsf@gmail.com> (raw)
In-Reply-To: <2E3DA4EF-E1F9-4B76-9053-506FC350F647@ur.rochester.edu>
Hi Marvin,
while what you have done may have fixed your error, I don't think it is
a correct fix. It could cause other issues and is an example of one of
those 'fixes' which will likely cause more subtle and difficult to
identify issues.
The 'org-open-lin-functions is supposed to be either nil or a list of
functions which take a single argument. What you have done is add t to
that list. This likely works as t evaluates to itself, but I think it
will completely break org's handling of [[link text]] style links
because when org runs this hook, it will always return t, telling org
that your custom functions have handled it. You may have tested your fix
and found that it looked like it worked, but note the details in the doc
string for that hook. i.e.
"They will be called for links that look like [[link text][description]]
when LINK TEXT does not have a protocol like "http:" and does not look
like a filename (e.g. "./blue.png")"
Your original error is due to something in your config adding a function
to that hook which does not exist. What you need to do is either define
that function (or find it's definition) or remove it from your config
i.e. remove the add-hook line which adds the function.
Note that the default setting is nil i.e. most installations probably
don't have anything in this hook unless they have some special url
format or they have added a package which provides custom url
handling. If you found the line and just changed the function name to t
as a fix, you can safely just remove the line completely.
HTH
Tim
Doyley, Marvin M. <m.doyley@rochester.edu> writes:
> Hi Nicolas,
>
> (add-hook 'org-open-link-functions t)
> Fixed the problem.
>
> Thanks
> M
>
>> On Aug 8, 2019, at 4:53 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>
>> Hello,
>>
>> "Doyley, Marvin M." <m.doyley@rochester.edu> writes:
>>
>>> Whenever I double click on an internal link I get the following error
>>> “void-function org-pass-link-to-system”
>>
>> The function above doesn't exist in Org base. You may want to
>> investigate on whatever is adding it to `org-open-link-functions'.
>>
>> Regards,
>>
>> --
>> Nicolas Goaziou
--
Tim Cross
next prev parent reply other threads:[~2019-08-10 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:56 Issue with internal links Doyley, Marvin M.
2019-08-08 20:53 ` Nicolas Goaziou
2019-08-10 0:16 ` Doyley, Marvin M.
2019-08-10 2:03 ` Tim Cross [this message]
2019-08-08 20:54 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0hdojyj.fsf@gmail.com \
--to=theophilusx@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=m.doyley@rochester.edu \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).