From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell Date: Thu, 20 Feb 2020 13:45:22 +0800 Message-ID: <87d0a995hp.fsf@gmail.com> References: <877e0kjbqq.fsf@gmail.com> <874kvnako5.fsf@gmail.com> <871rqrak5y.fsf@gmail.com> <87wo8ik22r.fsf@gmail.com> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:53855) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4eeY-0002Jz-SQ for emacs-orgmode@gnu.org; Thu, 20 Feb 2020 00:45:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4eeW-0003f5-UE for emacs-orgmode@gnu.org; Thu, 20 Feb 2020 00:45:38 -0500 Received: from [112.17.247.17] (port=53182 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j4eeW-0003aw-0R for emacs-orgmode@gnu.org; Thu, 20 Feb 2020 00:45:36 -0500 In-reply-to: <87wo8ik22r.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: Org Mode =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Jack Kamm writes: > Hi stardiviner, > > "numbchild@gmail.com" writes: > >> Yes, Jack, as Bastien said, you can format my commit, because my home >> network is broken, I'm using Mobile Phone's 4G network to get online. Ca= n't >> get update immediately. > > OK, I've edited the commit message of your patch, and I also fixed the > compilation warning by updating the signature of "(declare-function > py-shell)". > > Commit has now been pushed to master :) > >> And thanks for tips about `python-mode' is deprecated. I didn't know tha= t. >> I will migrate to `python.el'. > > Since python.el is built-in to Emacs, I think that things should > continue to work for python-mode.el users, even if we entirely switch > over to only using python.el. > > The only thing I'm not sure about, is whether the equivalent of > "python-shell-send-region" in python-mode.el will work with shells > started by python.el. If not, this could probably be addressed with a > patch to python-mode.el. > > You could test this by explicitly setting `org-babel-python-mode' to > `python' (it is probably set to `python-mode' on your system, which is > the default when python-mode.el is detected). > > I'll add a TODO for myself to explicitly mark python-mode-related > variables as deprecated. I'm also planning a major update to the Worg > documentation of ob-python when 9.4 comes out, and will mention the > deprecation there as well. Thanks for your work! Jack =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5OHPIUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsMoIAgAupUPheHI9UoqcB7MIAH6qOZoZKfi A7WurI++ioXEUN6rBlGkv/cNA2WsOm7TIjfLq1uXIEHvfgLY4nM+0YQJmPX1XzGr ej+xNO+9sjwrXA83XELM5DcGhat2C3PBE0ANqZIeZxnE1roUOcYVCdIdrPsvrpWC /nSHIEB3fg19lq+QGwr17qXqLsNy/BjytixWclHQz9bmA5Cs9p9jGPDIamrEK+4w 7/1QMXg1B3GUPWrRLUfeMV3hye+btpPZOqVpk1OwVg0AJpp4brI/OvkzOrfDMhA4 fxjB/JE2Ll4hvN+MSJ0wGohMUIvClm9Li6jWsKmC1ZHtAdzn5lkKQ2nspA=3D=3D =3DVCww =2D----END PGP SIGNATURE-----