From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mNgDCf8r3l56YwAA0tVLHw (envelope-from ) for ; Mon, 08 Jun 2020 12:15:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QH7nBP8r3l7LYgAA1q6Kng (envelope-from ) for ; Mon, 08 Jun 2020 12:15:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B37099407C7 for ; Mon, 8 Jun 2020 12:15:58 +0000 (UTC) Received: from localhost ([::1]:47264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiGh3-0003dy-Mi for larch@yhetil.org; Mon, 08 Jun 2020 08:15:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiGgA-0003dC-Jy for emacs-orgmode@gnu.org; Mon, 08 Jun 2020 08:15:02 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:39954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiGg9-0000MG-9z for emacs-orgmode@gnu.org; Mon, 08 Jun 2020 08:15:02 -0400 Received: by mail-ej1-x643.google.com with SMTP id q19so18025214eja.7 for ; Mon, 08 Jun 2020 05:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=VWrkNGStya+eTjRzUZ44ZzfqzozyaHphMoLvba4O6xQ=; b=AqA9uFX+29cy6hQ6D93Fz6HInSOFekZgwnHL2zm52Ir9zb+7FA5ieMxKq4Z+9TnmY3 B/g7kAZjyVMOj+R9hPh+AthkyICbZsi/DLSqntX0ICV0BgdNV9A0w5oboLdtxIoSsTuH 3P9hO7M1q4ZYPMc4FeAg2l9uTasjaj3ay4aKccyoq828JnBkwn7H+DRzPpd4+R6ZRzfH wu7D1TXLSk7TT5k3VKQvdR6QP6CVpt60nzEZ8yjjTaPxodfaKRvGw6nZGCmCjQd/r8Bk hlocvQvAlp0QtBGrtPAYp99j6Xts1FFn2OdiWw/aSGfkLQaAToX/BnTwTnBe1M0bez5G 6FVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-transfer-encoding; bh=VWrkNGStya+eTjRzUZ44ZzfqzozyaHphMoLvba4O6xQ=; b=AZCpwdeX/SFCVuqnDU5nnNnlvLmwyLYat/xJat4wwkZreLf3aqsmwDmBC7gRCP+lu4 F9+AyhPRhCSVvTasgBpmEA8bPiVlLXLHqKgbRO75QFpl9yk2D4u3/VC4bVqnSxkVp9f8 VT67SqLgfa4agoLGBOKuaY7DabLIb/FECtFnjdyUpQ2x2scX/1BiCK4tqIqVzsEQTz+x 7gm6XjIYdiVPBDgy7XbrWXNxTOaIDs0G65ZwBRszUJYRCUlxK/vZLhyiOby47+/AMG49 B0GAVBepQiZEKG4g4WPgdTfw3cHC/1DJOGP2dYTYOtVmxnCGoQRuwhqvApsus/ajVIZ9 XHnw== X-Gm-Message-State: AOAM532JjMO5r0IHHxvhgq1zwOd3a6CQKo05/WPDx1vCFbTWWPFmGgow h3PeFRmF6G+aqbysal+TK8sGMVI= X-Google-Smtp-Source: ABdhPJwILDBmT6szHwapHYFgwv+QLgVlM0TeVfQT6ZSa2SyEeALV6CQxhFwKEYziXXvxXCOVleYfHw== X-Received: by 2002:a17:906:ccdd:: with SMTP id ot29mr19986465ejb.119.1591618498765; Mon, 08 Jun 2020 05:14:58 -0700 (PDT) Received: from thinkpad.localdomain (5.7.9.93.rev.sfr.net. [93.9.7.5]) by smtp.gmail.com with ESMTPSA id f13sm12619258edk.36.2020.06.08.05.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 05:14:58 -0700 (PDT) From: Leo Vivier To: Nicolas Goaziou Subject: Re: [PATCH] org-element.el: Fix properties being upcased by parser In-Reply-To: <87mu5d7opp.fsf@nicolasgoaziou.fr> References: <87h7vl3l1v.fsf@hidden> <87mu5d7opp.fsf@nicolasgoaziou.fr> Date: Mon, 08 Jun 2020 14:14:57 +0200 Message-ID: <87d0693gam.fsf@hidden> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=leo.vivier+dev@gmail.com; helo=mail-ej1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=AqA9uFX+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: xtlGH+sE2s5V Hello, Nicolas Goaziou writes: > This is unrelated to capitalization usage in Org buffers. Upcasing is > used to tell the difference between, e.g., :value and :VALUE. I understand, but I think the function is also used to modify file-parameters like `#+title`. If you run `org-element-parse-buffer` on a buffer with the following content: --------------------------------[START]-------------------------------- #+title: Foo ---------------------------------[END]--------------------------------- Here=E2=80=99s what you get: --------------------------------[START]-------------------------------- (org-data nil (section (:begin 1 :end 14 :contents-begin 1 :contents-end 14 :post-blank 0 :post-affiliated 1 :parent #0) (keyword (:key "TITLE" ; <---------- :value "Foo" :begin 1 :end 14 :post-blank 0 :post-affiliated 1 :parent #1)))) ---------------------------------[END]--------------------------------- This caused us some head-scratching when we updated Org-roam to use lower case file-parameters. Here=E2=80=99s how my Edebug session went: org-element-parse-buffer -> org-element--parse-elements -> org-element--current-element --------------------------------[START]-------------------------------- ((looking-at "\\+\\S-+:") (beginning-of-line) (org-element-keyword-parser limit affiliated)) ---------------------------------[END]--------------------------------- Ultimately, it=E2=80=99s not changing anything for the users, but I did fin= d it a little counterintuitive. HTH, --=20 Leo Vivier