emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] capture: respect KEYS with GOTO arg [9.3.7 (release_9.3.7-661-g4aa4dd @ /home/n/.emacs.d/straight/build/org/)]
Date: Fri, 03 Jul 2020 02:34:46 -0400	[thread overview]
Message-ID: <87d05dcdix.fsf@kyleam.com> (raw)
In-Reply-To: <87mu4j8697.fsf@gmail.com>

No Wayman writes:

> `org-capture' does not pass its KEYS argument to 
> `org-capture-goto-target'.
> (Must not be a common use-case, as git blame points to 
> org-capture's introduction 10 years ago!)
>
> The attached patch does just that.

Thanks for the patch.  Indeed it looks like an oversight went unnoticed
for a long time.

> Wasn't sure if this was worthy of a NEWS entry. Will add if 
> needed.

In my view it doesn't require an entry.

> Subject: [PATCH] capture: org-capture pass KEYS with GOTO arg
>
> * org-capture.el (org-capture): pass `keys' arg to `org-capture-goto-target'.

After applying, I added "lisp/" in front of the file name and
capitalized "pass".

Pushed (99b8f36ab).


  reply	other threads:[~2020-07-03  6:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 18:00 No Wayman
2020-07-03  6:34 ` Kyle Meyer [this message]
2020-07-05  6:14   ` No Wayman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d05dcdix.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --subject='Re: [PATCH] capture: respect KEYS with GOTO arg [9.3.7 (release_9.3.7-661-g4aa4dd @ /home/n/.emacs.d/straight/build/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).