From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cKHFBej+WF/5JgAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 16:12:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iNCWAej+WF8EUgAAbx9fmQ (envelope-from ) for ; Wed, 09 Sep 2020 16:12:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 937B4940414 for ; Wed, 9 Sep 2020 16:12:23 +0000 (UTC) Received: from localhost ([::1]:56552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG2hq-0005GT-KH for larch@yhetil.org; Wed, 09 Sep 2020 12:12:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG2hG-0005EM-Vg for emacs-orgmode@gnu.org; Wed, 09 Sep 2020 12:11:47 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:53379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG2hE-0005zW-LY; Wed, 09 Sep 2020 12:11:46 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 38E9520000F; Wed, 9 Sep 2020 16:11:39 +0000 (UTC) From: Nicolas Goaziou To: Bastien Subject: Re: [PATCH] org-element: Hide parsers boilerplate into plist-creating macros References: <87imco6vaj.fsf@gmail.com> <87r1rbl4ll.fsf@gnu.org> Mail-Followup-To: Bastien , akater , emacs-orgmode@gnu.org Date: Wed, 09 Sep 2020 18:11:38 +0200 In-Reply-To: <87r1rbl4ll.fsf@gnu.org> (Bastien's message of "Wed, 09 Sep 2020 10:46:46 +0200") Message-ID: <87d02vlykl.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 12:11:40 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, akater Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: qR2ZoEHitLZA Hello, Bastien writes: > akater writes: > >> We replace some repetetive code with macro calls org-prog-plist and >> org-let*-prog-plist. > > IIUC this is a refactoring, it does not add or remove functionalities? > > I'll let Nicolas decide on this, of course. FWIW, I'm not convinced there's a significant advantage in doing this refactoring. Arguably, the code is not more readable. It will not make it faster either. There is room for refactoring in Org (for the record, org-agenda.el has not switched to lexical binding yet), but I don't think org-element.el has bitrotten so much that it deserves some. Regards, -- Nicolas Goaziou