From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iCxkAK5M2l+7QAAA0tVLHw (envelope-from ) for ; Wed, 16 Dec 2020 18:06:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yMZENq1M2l9lGgAAB5/wlQ (envelope-from ) for ; Wed, 16 Dec 2020 18:06:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CA809403CB for ; Wed, 16 Dec 2020 18:06:37 +0000 (UTC) Received: from localhost ([::1]:39506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpbC6-0005UX-DZ for larch@yhetil.org; Wed, 16 Dec 2020 13:06:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpbBR-0005Tq-Gr for emacs-orgmode@gnu.org; Wed, 16 Dec 2020 13:05:53 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:33750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpbBO-0006pd-Pu for emacs-orgmode@gnu.org; Wed, 16 Dec 2020 13:05:53 -0500 Received: by mail-wr1-x434.google.com with SMTP id t30so6042675wrb.0 for ; Wed, 16 Dec 2020 10:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8fsxcYB4y5mhjCP4hy1JP3qIFYev+CZ/uSyTJ71FBvM=; b=Y412NQS07GUVZLgO0rnnDlocMQRn7JTK427NptZyvYz6cU5C+riTbBO6AiE9GTgBhD NlTIsJh1NLl7ZRHwKrj0JiD6ITIJkwmxK8flLn9j3vwVOQilVIro4NVEo1B2eJWgBaBV EQ0h6JBP77YuRk9oogxDQsdUAhLeBEGnMBgcoOG+APVfs+wAPX9TJOPxckTwqx+vmA8D OiHZMebPZD2gRyVS6Tsnh0lwkj1UlWluYyayMopsNix4a9i2C4m0GL4BzZp5suyYRVnC Zz3WIfPdnOaMfn4H5vp42oAP2AvUv6I1Ey06lOq8SHKsHccixUoQ13xPR8AwKJD+zUMw rWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8fsxcYB4y5mhjCP4hy1JP3qIFYev+CZ/uSyTJ71FBvM=; b=irTh8w7GT5DsTGJ5aV7dFU9kky+8HysFBPzdI/JWvDaeO/x7DVf6v1w/34v1+EGxsB H9FV4emjI+05V7oUHRsv35LI10J/aO/xnTB9ovNnYLM7Y0jNPBBjdsNaZsYXmYt8MU04 p79b3aElI1lwbOIMUotNfdQ1BLjdTc7fr7oqQ8Qv9ttk09au45mgk3JKix9TAjTJg6W+ S3oVR5wMQEm+BTBEJPEZmlaN8XmbzFXLN3J7IQ/WEnEWkyVu6iR45DN/8JpZSeSDrdOu jgZzmAYNf7cNe2fIOimUCKEZTsEr8CcIlgO9pDUMY0+QwtAcikAEJdLe3vH4WbJ70E5L SP7Q== X-Gm-Message-State: AOAM532hBFcKJtMrbqPBplbpe1N9AxwHF+OG9X4xoDoxrV4gEh4lHBDE AAetTWhIkJI9GCnrzPdoNTZQjvGSdhtKbA== X-Google-Smtp-Source: ABdhPJzOP5Vbu8T/KJmurcbxHGC43DB6FHIaSIHsNnZnsXcObew0KnLP2+3RZunl/OScEf1h2w3fJg== X-Received: by 2002:adf:9cca:: with SMTP id h10mr32314678wre.77.1608141948432; Wed, 16 Dec 2020 10:05:48 -0800 (PST) Received: from my-little-tumbleweed ([2a01:e0a:20e:d340:922b:34ff:fe95:9aed]) by smtp.gmail.com with ESMTPSA id z15sm4497315wrv.67.2020.12.16.10.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 10:05:47 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Ihor Radchenko Subject: Re: [9.4] Fixing logbook visibility during isearch References: <87h7x9e5jo.fsf@localhost> <87sgfn6qpc.fsf@nicolasgoaziou.fr> <87367d4ydc.fsf@localhost> <87r1uuotw8.fsf@nicolasgoaziou.fr> <87mu5iq618.fsf@localhost> <87ftb9pqop.fsf@nicolasgoaziou.fr> <875zc2du63.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com> <87sgbaw58y.fsf@localhost> <87pn6ew2pv.fsf@localhost> <8736393tlw.fsf@gmail.com> <87eemtm1ic.fsf@localhost> <875z83hwuc.fsf@gmail.com> <874knm61p3.fsf@localhost> <87r1nrdl5o.fsf_-_@gmail.com> <87r1nqjv9w.fsf@localhost> Date: Wed, 16 Dec 2020 19:05:46 +0100 In-Reply-To: <87r1nqjv9w.fsf@localhost> (Ihor Radchenko's message of "Wed, 16 Dec 2020 11:15:55 +0800") Message-ID: <87czz91v9h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.01 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Y412NQS0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 4CA809403CB X-Spam-Score: -3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: KhdiEfHrgFQo Ihor Radchenko writes: > K=C3=A9vin Le Gouguec writes: > >> The debugger only fires *after* we exit isearch, and by that time it's >> too late: my issue comes from all those logbooks cluttering the screen >> while I'm mashing C-s to iterate through matches. >> >> I can try to dig deeper into this, but before doing so: would you have >> any insight as to what's going on here? > > org-mode is relying on default isearch behaviour during interactive C-s > session. By default, isearch simply makes all the overlays at match > visible and re-hide them once we move to the next match. In case of > org-mode, this reveals drawers as well, since they are in the same > overlay with the rest of the folded heading. > > The way to change default isearch behaviour *during* isearch session is > setting undocumented 'isearch-open-invisible-temporary property of the > overlay (see isearch-open-overlay-temporary). Thanks for taking the time to explain this. I can't find any reference to this property in Org <9.4 (e.g. 9.3 as shipped in 27.1, where the bug does not happen) so do I understand correctly that the root cause ("since [drawers] are in the same overlay with the rest of the folded heading") dates from Org 9.4? (Just trying to understand if I should keep looking at Org 9.3 for inspiration, or if your proposed solution based on isearch-open-invisible-temporary should be implemented from scratch)