emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] bad table formula recorded in some cases
@ 2021-07-08 16:04 tbanelwebmin
  2021-07-21 10:50 ` Timothy
  2021-09-26  6:55 ` Bastien
  0 siblings, 2 replies; 6+ messages in thread
From: tbanelwebmin @ 2021-07-08 16:04 UTC (permalink / raw)
  To: Org Mode

Small bug, small fix.

Suppose we have a table embedded in a begin-end block.

#+begin: aaa :param value
| a | b |
| a | b |
#+end:

Suppose we want to add a formula, with C-c =
We end up with an incorrect result:

#+begin: aaa :param value
| a | 33 |
| a |  b |
 :param value $2=33
#+end:

The fix: in org-table.el, line 2177, change
  (insert (or (match-string 2) "#+TBLFM:")))
to
  (insert "#+TBLFM:"))

Then we get the correct result:

#+begin: aaa :param value
| a | 33 |
| a |  b |
#+TBLFM: $2=33
#+end:
 
Why? Because (match-string 2) is supposed to refer to the (looking-at)
instruction 7 lines above. But (match-string 2) is in the else branch,
which means that (looking-at) failed. Therefore (match-string 2) returns
garbage.

Thanks to Uwe Brauer for pointing to this bug.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-26  6:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 16:04 [PATCH] bad table formula recorded in some cases tbanelwebmin
2021-07-21 10:50 ` Timothy
2021-07-21 14:25   ` tbanelwebmin
2021-07-21 15:07     ` Timothy
2021-07-21 18:37       ` tbanelwebmin
2021-09-26  6:55 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).