From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8vlhEobVq2FDfwEAgWs5BA (envelope-from ) for ; Sat, 04 Dec 2021 21:54:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YLUvC4bVq2EqcgAAB5/wlQ (envelope-from ) for ; Sat, 04 Dec 2021 20:54:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 49F9B40A9 for ; Sat, 4 Dec 2021 21:54:29 +0100 (CET) Received: from localhost ([::1]:39972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtc3A-00080L-GR for larch@yhetil.org; Sat, 04 Dec 2021 15:54:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtc2a-0007zv-NZ for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 15:53:52 -0500 Received: from sanpietro.red-bean.com ([45.79.25.59]:53446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtc2X-0006L5-Md for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 15:53:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:Subject:To:From:Sender:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=KFLDNP+0ad0g64toRDUozo7IixmFDhfYiskr4dSoS6U=; t=1638651228; x=1639860828; b=SBjcnD/e/IgF5/2ivJ0qHKA/tpnGjQjV90QFgkEZNkn/HnXfycfeUyNYMUoWLp81nTJpKBbIYFx j88qT87GkILBnt5GLLxjpu7IHqb+NXk0n77XwtdngDMNKHU/d42yKyK7cxb/TFxdp5szpFW3ZmqmC pIDcyORh3EpmpXnmHf5y30YMjnioF1Qyzkj1DYPpIv+yXAouceTiNfotu7/RU+TwE4F/rtHDZdBJ1 +yqAK0sdVlreUrH890+0tdwirsZjBZMd10x8wAaTxssbC1lU0jVliDBGrmB3GWD/iv1tlzvtVbtiu jspxTBmmkikk0C97ZuZgRGf/JwWlDFo5D39A==; Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:60562 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mtc2V-009BdY-6y for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 20:53:47 +0000 From: Karl Fogel To: Org Mode Subject: Removing obsolete function `org-truely-invisible-p'. Date: Sat, 04 Dec 2021 14:53:46 -0600 Message-ID: <87czmcccrp.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Karl Fogel Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638651270; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KFLDNP+0ad0g64toRDUozo7IixmFDhfYiskr4dSoS6U=; b=j/BNdf6Sn2bF8WWjAkNMwaniJunhp90q2eNcCpKu7KI2LzR3bU3DZKqek737UjIMGaJzd9 sn4LssdxM0O8TBCmIn80nCY9TvkY1WYsa2J/LFMGFjviNP7OhZ9k/l3ap1Ph5jAGsDBmRn 9I4saMV33kVM6pFxlG2dAgcALW6X3Qmf0EqZvjvjurNW3WL8vBZIKPWTNTUUeUQdkWR7qu PVU78OiV76GTcpP0ksjJ2u18w4gg5qE4RAiCNWAXEq7pYrh2zba8a0BW0bB8aFfEIYHym/ uokhX2u/vB7jbQ1Qjb8MtznX6qTA1E5mSb7b8EymGa3jpGyn97HpoeMJtnCHkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638651270; a=rsa-sha256; cv=none; b=PJ7vtUejk8YFCKRnds2HrXOPXN9K1juVWrNQo4E9uWBS/p1jYLbibIGEl4xFDpfnB4sl05 EBeWrbSPJkYeF+I6Tv0XKuPVrFZq5aHTq85Mf61mj7loeRjG0ZsJL6eEPK18Fx0c4FJRUe 7J82e/XaLYplYdCTcrFdqQi08CzLp/zvaW7lS4doEP5MiT0GzgKIwsSMzhay1sP1M25fhe /sHKKjj916CJeCP0O5YZZHpSPSVSrayvDfrZo3Ufiq2VP5BD0Ovf0bkv/UkNIi7p6aoqig RBCeu3+gb8P1NEVaCxAtlRqhmh3/Y5r+bQbLkeYEkaQBooJGlFT1QfBCy0qy9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b="SBjcnD/e"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b="SBjcnD/e"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 49F9B40A9 X-Spam-Score: -1.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: jia2hrCwp7F+ The function `org-truely-invisible-p' is defined in 'lisp/org-macs.el', but it is not used anywhere anymore in Org Mode, nor is it used anywhere in GNU Emacs (I checked on both 'emacs-28' branch and 'master' branch). The last (and possibly only?) call to that function was removed from `org-beginning-of-line' in this commit: commit 3baf246f4f73005a4eacd7c368f7222f95d50243 Author: Nicolas Goaziou AuthorDate: Thu Apr 28 23:28:15 2016 +0200 Commit: Nicolas Goaziou CommitDate: Thu Apr 28 23:28:15 2016 +0200 Handle correctly `shift-select-mode' * lisp/org.el (org-beginning-of-line): Handle correctly `shift-select-mode'. Reported-by: Mathieu Marques Then, a few months later in commit 87116700e6e, Nicholas moved the function to 'org-macs.el', where it has been sitting unused ever since. Should we just remove `org-truely-invisible-p'? Or at least correct the spelling of its name ("truely" should be "truly")? It seems fairly unlikely to me that people are using it in their own code, although of course I cannot be sure of that. Partly, I believe that because surely someone else would have noticed the misspelling by now, if enough people were using it :-). Best regards, -Karl