emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: Ignacio Casso <ignaciocasso@hotmail.com>, emacs-orgmode@gnu.org
Subject: Re: [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]
Date: Tue, 05 Apr 2022 00:20:51 -0400	[thread overview]
Message-ID: <87czhw2mak.fsf@kyleam.com> (raw)
In-Reply-To: <20e6f6ec-de72-fcdf-87a6-717efec931d1@gmail.com>

Max Nikulin writes:

> Confirmed
>
> Emacs copy of Org changed the way of calling `encode-time' as a result 
> interpretation of last nils returned by `org-parse-string' altered from 
> ignored to "no DST".
>
> Kyle, be aware of the conflict with `org-time-string-to-time' when you 
> will port emacs commit dd0727e1ec1f535b9b06be88173b4d3ccd55abcb
> Paul Eggert <eggert@cs.ucla.edu> Thu Dec 16 09:40:21 2021 -0800
> encode-time simplifications

Thank you, Max, for looping me into the discussion (and thanks, Ignacio,
for the initial report and debugging).

> New calling convention for `encode-time' exists since emacs-27.1, so it 
> is incompatible with yet supported emacs-26. [...]

>> So I guess this is an Emacs 29 bug? I didn't know the two repositories
>> could diverge like that. Should I report it to Emacs 29 maintainers?
>> Or can org-mode maintainers fix it in the Emacs repository?
>
> The problem is a consequence of grep-refactoring of Emacs code, but 
> likely it should be fixed at the Org side.

The long tail of 9e1b9fe62 (Port more time-related changes, 2019-08-18)

My suggestion:

  1. Send a report to bug-gnu-emacs@gnu.org describing the issue.  Ask
     that Paul revert those changes.

     I can do this at some point this week.

  2. Audit and update the call sites on our side, along with some
     compatibility layer.

The first isn't necessary, but it avoids the problem living in the Emacs
master branch until the updated Org code base (main branch) is synced
with it (which hasn't started yet).


  parent reply	other threads:[~2022-04-05  4:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 13:09 Ignacio Casso
2022-03-30  7:13 ` Ignacio Casso
2022-03-30  9:48   ` [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day Max Nikulin
2022-03-30 10:17     ` Ignacio Casso
2022-03-31 12:38 ` [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] Max Nikulin
2022-03-31 14:11   ` Ignacio Casso
2022-03-31 16:57     ` Max Nikulin
2022-03-31 21:37       ` Tim Cross
2022-04-05  4:20       ` Kyle Meyer [this message]
2022-04-22 15:47         ` Max Nikulin
2022-04-23  7:20           ` Ignacio Casso
2022-04-23  8:23             ` Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czhw2mak.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ignaciocasso@hotmail.com \
    --cc=manikulin@gmail.com \
    --subject='Re: [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).