emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: erimius@web.de
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: Bug: org-deadline drops warning periods from TIME [9.4.6 (9.4.6-10-gee652a-elpaplus @ /home/fap/.emacs.d/elpa/org-plus-contrib-20210712/)]
Date: Sun, 15 May 2022 14:51:02 +0800	[thread overview]
Message-ID: <87czgf2srt.fsf@localhost> (raw)
In-Reply-To: <87o85bl582.fsf@localhost>

Ihor Radchenko <yantar92@gmail.com> writes:

> erimius@web.de writes:
>> * Reproduction
>> Call ~org-deadline~ with a warning period like so:
>> (org-deadline nil "<2021-07-20 Tue -1d>")
>>    ;; => DEADLINE: <2021-07-20 Tue>
>> * Expected
>> Deadline gets added with the warning period provided.
> Can you try the attached patch?
> Also, note that warning period is still not supported when reading
> deadline interactively. Not sure if we need it though.

Applied onto main via cdbb1c963.

I changed the patch adding support for timestamps with repeaters _and_
warning. Also, added the relevant tests.


      reply	other threads:[~2022-05-15  6:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 15:09 Bug: org-deadline drops warning periods from TIME [9.4.6 (9.4.6-10-gee652a-elpaplus @ /home/fap/.emacs.d/elpa/org-plus-contrib-20210712/)] erimius
2021-08-31 15:55 ` Timothy
2021-12-20 14:29 ` [PATCH] " Ihor Radchenko
2022-05-15  6:51   ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czgf2srt.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=erimius@web.de \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).