From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gA3zBiWi4mKItwAAbAwnHQ (envelope-from ) for ; Thu, 28 Jul 2022 16:50:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8HPRBiWi4mJTkgAAauVa8A (envelope-from ) for ; Thu, 28 Jul 2022 16:50:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D623D3F372 for ; Thu, 28 Jul 2022 16:50:12 +0200 (CEST) Received: from localhost ([::1]:38254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH4q3-00058a-Fl for larch@yhetil.org; Thu, 28 Jul 2022 10:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4XO-0004MN-8g for emacs-orgmode@gnu.org; Thu, 28 Jul 2022 10:30:55 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:54263) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oH4XK-0003pw-Vq for emacs-orgmode@gnu.org; Thu, 28 Jul 2022 10:30:54 -0400 Received: by mail-pj1-x1035.google.com with SMTP id pw15so2019928pjb.3 for ; Thu, 28 Jul 2022 07:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=8vW81B6mmjR+trwLtXBMv/20jLsNpLmeeW92VEVAb4g=; b=pFO9m9RYGEl3aUwglQdWgWgOwE1FgPc/FholTmrFGCyK0wcMHaLthIP8pBu3+ZJtft cs20p499HDCr6rkdD8AEpKXRiIP2W5DxD7WvwVVAx450Wd4J8ihxeckJUIgMPJ85TYNx 6/0T7HYTADxYC15sSokfZ7k7WH1HOTraAPQNvtq5RayNLGMdfNuoBT5IF/PJ5R2Z9XVw VIw3V/RBdrtad8u6DzgS/DTf9O2yObzMGYzNJCjoGuY9y8KC4FmsVpZG5mYxbc0LHd8g 9f6eOLA6/OgUYb5cqLEC5wwb3wvYegNRXo1fWJ8buu4QDuR5iiTyM2Dk2Hc9adlJmzcK IqTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=8vW81B6mmjR+trwLtXBMv/20jLsNpLmeeW92VEVAb4g=; b=7qCZz+Ylx0UfIIqqG0KjgMNeGXnW2JZpel+nzgSn6qVvzB/81hTJAB6G6SCXVXKUm9 OdocgBJhKKORNQ3sqd5Qs1ok7H1sxcEu0CRZhxrU+bTiZwPPIfFkEsQ0RfPXrmTShGSO 3B7teda8Zs7J051qoV8EFYDHneLrLR2fZG+fFyAGl7uCPNHnHGz74SWkBDRRpfIJJ06v mH41G39WHO8GPLg3Wt3VHMWLOT42mDwV4ngWQPsMpAGFibTaoIm31Bj9OtbOPmEgTUKt 5hNQYB9bDUjmw+yl3cJXa1/o8tuYB1IP+HD9hZkRzg+KjG3rCl4VXZfz7reFMNRnk6DT 3SwQ== X-Gm-Message-State: AJIora/eMH9Yw5jtKYKlokq6P1YrRoy52VlMF3g1Rr7KkE84FHJMppXi ECHolDQND7tXFKruFd0yOFRZgJa6OGs= X-Google-Smtp-Source: AGRyM1t/bGAOW9zkMK070l89p/IeaZ7xGiq81qje0xYZg/mimrYbv/K/NIZyMKscY2DKrFZfW4Hy0Q== X-Received: by 2002:a17:902:e88b:b0:16d:8a17:5abf with SMTP id w11-20020a170902e88b00b0016d8a175abfmr16006364plg.51.1659018649619; Thu, 28 Jul 2022 07:30:49 -0700 (PDT) Received: from localhost ([2409:8a70:217:4f80:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id y1-20020a17090322c100b0016d231e366fsm1477619plg.59.2022.07.28.07.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 07:30:48 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-test: Run all ol tests on make test In-Reply-To: References: <218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com> <874jz3b4fb.fsf@localhost> Date: Thu, 28 Jul 2022 22:31:51 +0800 Message-ID: <87czdp9ulk.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659019812; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8vW81B6mmjR+trwLtXBMv/20jLsNpLmeeW92VEVAb4g=; b=frOSz0Vu69FRMZ7C+v6RDRT3SGVqa6cDRhoAAG+FHMbkMsvjzdk037fDIxLLVK3xYczTdA XQhd6W9AglJvLE640pzVLnC+oISwtHR0PeiUarCK/UyoSRXIgOdjejPQpakrYZiyxcyR+T GOmjNTDS96ZhNoc4poVm/PuZi+4xfW3HGC22ozOVGQFgrwD695SM6jjb664+N6KYzuOv0M TO1yxBC6n7GyD5cvI6cTEvC1ahFn78IiJUGEHBnUj24JJQER1k7JTSxdIvQBn2zfuvpIc8 ZtetyQQMdPFlazHttDwGD8O3SQV2FHy2wfeI+9GQRVIG17q0mQ1Al3lkg0d8qA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659019812; a=rsa-sha256; cv=none; b=QPz6Dsgz/TLcV75tGoos1PStENfT/pHnniOt+RvG9FXOD3VBYEvpz2Qz+BBTqniavHwiKd 1eP3vQMxEgRvFb3P3VIXcR1HcRfwuNr3F0rkJWGieTDhjCaWgXGdUyztXyDDyKREg29SoM jqyKPD8bxjLrtG8zKMPDxvIwPPzoYdgSEg9O/xVXx3BpiwgHyPM/n1HmxpzTqYJF8jLcym emhByhTg0nULE1tObYcbYifTwXtGusNjyvmMCckljPlngLXvmdhVW/PS8QApugWnjJ1in5 vqFjYRKaGx4E36LXgE41/RNZAUImOX+ydLtmizs7A+D3W7mEz0hjTeatJ6ROBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pFO9m9RY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.43 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pFO9m9RY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D623D3F372 X-Spam-Score: -8.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: f3YkuSPsB0bi Max Nikulin writes: > On 27/07/2022 10:49, Ihor Radchenko wrote: >> >> You missed the >> >> (org-test-selector >> (if org-test-selector org-test-selector "\\(org\\|ob\\)")) > > I have notices that cases in test-oc.el are named test-org-cite/... So I > am considering renaming tests in test-ol.el in the same way from > test-ol/... to test-org-link/... instead of modifying selectors. I have > not noticed with approach to naming is recommended. Either way is fine. Ideally, we should stick to org- prefix, as expected from Elisp conventions. But we are already kind of breaking this convention by having all the oc- ol-, etc files. Best, Ihor