From: Jack Kamm <jackkamm@gmail.com>
To: tomas@tuxteam.de, Ihor Radchenko <yantar92@posteo.net>
Cc: "Stephen J. Eglen" <stephen@eglen.org.uk>,
emacs-orgmode@gnu.org, mail@nicolasgoaziou.fr, steuer@hsu-hh.de
Subject: Re: Bug report for ox-icalendar: newlines should be CRLF
Date: Sat, 15 Apr 2023 22:01:16 -0700 [thread overview]
Message-ID: <87cz44beub.fsf@gmail.com> (raw)
In-Reply-To: <87ildyberp.fsf@gmail.com>
Jack Kamm <jackkamm@gmail.com> writes:
> <tomas@tuxteam.de> writes:
>
>>> > There is a related issue about EOLs, not just \r\n -- each line should
>>> > be a maximum of 75 characters; this is handled by
>>> > org-icalendar-fold-string
>>>
>>> May you please provide a link to the iCalendar spec document section
>>> describing this requirement?
>>
>> It's in rfc5545 [1], referenced to from rfc7986 [2].
>
> Since VEVENT and VTODO are wrapped in `org-icalendar-fold-string', I
> think the only place this error may occur is in the preamble created by
> `org-icalendar--vcalendar', e.g. in PRODID, X-WR-CALDESC, etc.
>
> The fix is to move the call to `org-icalendar-fold-string' out of
> org-icalendar--vevent/vtodo, and instead put it in
> `org-icalendar--vcalendar'. Then the line folding will apply to the
> whole VCALENDAR instead of just the VTODO and VEVENT. An earlier version
> of my CRLF patch actually did something like this.
>
> I can push such a fix over the weekend. Let me know if you'd rather I
> send the patch for review here first.
I've pushed this change now:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f4446ce795c924a1e115e360d3674f6ad89be845
next prev parent reply other threads:[~2023-04-16 5:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 8:30 Bug report for ox-icalendar: newlines should be CRLF Stephen J. Eglen
2023-01-08 8:50 ` Detlef Steuer
2023-02-01 14:51 ` Ihor Radchenko
2023-04-02 20:42 ` Jack Kamm
2023-04-03 8:09 ` Stephen J. Eglen
2023-04-14 10:13 ` Ihor Radchenko
2023-04-14 10:45 ` tomas
2023-04-14 16:38 ` Jack Kamm
2023-04-16 5:01 ` Jack Kamm [this message]
2024-01-12 13:54 ` Ihor Radchenko
2023-04-15 9:07 ` Stephen J. Eglen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz44beub.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=stephen@eglen.org.uk \
--cc=steuer@hsu-hh.de \
--cc=tomas@tuxteam.de \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).