From: Ihor Radchenko <yantar92@posteo.net>
To: Hammer Hu <hammer@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Incorrect indentation when there are invisible/diplay properties on the line [9.6.7 ( @ /home/huzf/.cache/emacs_configs/default/elpa.28/org-9.6.7/)]
Date: Tue, 11 Jul 2023 15:07:52 +0000 [thread overview]
Message-ID: <87cz0y7agn.fsf@localhost> (raw)
In-Reply-To: <grtblkkjngjz6bfneucdyulwlbh5vus3jzn4wumk52iyuyov33@gt3q3zuvz3ga>
Hammer Hu <hammer@posteo.net> writes:
> Please change bug.el to
>
> (add-hook 'org-mode-hook #'org-modern-mode)
> (setq-default org-adapt-indentation t)
>
> Select the region and M-x indent-region <RET> multiple times.
Thanks!
A simpler reproducer:
1. /tmp/bug.org
#+begin_quote
foo
#+end_quote
2. emacs -Q -L /path/to/compat/ -L /path/to/org-modern/ -l compat -l org-modern /tmp/bug.org
3. M-x org-modern-mode
4. Move to the beginning of #+begin_quote line
5. M-: (indent-line-to 3) <RET>
6. M-: (indent-line-to 3) <RET>
7. <can repeat>
8. M-x org-modern-mode
9. Observe overindentation
The reason why this happens is the following:
1. indent-line-to tries hard to create indentation and move the
beginning of visible text to column 3.
2. indent-line-to notices (at point (5)) that line is not indented at
all.
3. It computes that it should insert " " to indent to column 3 and
inserts these spaces.
4. org-modern-mode notices modification and re-hides spaces
5. indent-line-to is fires one more time at point (6)
6. indent-line-to notices that line is indented, but the leading
whitespace is invisible.
7. It computes that it should yet insert extra " " to move the text
to column 3 visually (because the existing spaces are hidden).
8. It inserts the extra spaces
9. org-modern-mode notices modification and re-hides added spaces.
I believe that it is org-modern's fault. Indentation works are it
supposed to and tried hard to align text visually to third column.
org-modern fights against.
Note that indenting visually is Emacs' convention that applies
everywhere.
Canceled.
Not an Org mode bug.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-11 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:22 [BUG] Incorrect indentation when there are invisible/diplay properties on the line [9.6.7 ( @ /home/huzf/.cache/emacs_configs/default/elpa.28/org-9.6.7/)] Hammer Hu
2023-07-11 11:28 ` Ihor Radchenko
[not found] ` <44rsvv2dwp2cnpbikqs7kysct5ylsxivm3scirj55efm7qvwat@flec34dbbdbb>
2023-07-11 13:22 ` Ihor Radchenko
2023-07-11 13:49 ` Hammer Hu
2023-07-11 15:07 ` Ihor Radchenko [this message]
2023-07-11 15:29 ` Hammer Hu
2023-07-12 8:42 ` Ihor Radchenko
2023-07-12 17:43 ` Hammer Hu
2023-07-12 17:48 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz0y7agn.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=hammer@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).