From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uLbqMmfJr2QGbgEASxT56A (envelope-from ) for ; Thu, 13 Jul 2023 11:52:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uMwWMmfJr2RkQwAAG6o9tA (envelope-from ) for ; Thu, 13 Jul 2023 11:52:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D745400FC for ; Thu, 13 Jul 2023 11:52:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MHYzgKCC; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689241959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4YtvLIkfQmnknTLKnFvC2fCaJTy4Jd2FMhVCpXifzcc=; b=VO77HQPgbxH4YOBIa0xw5OIMLzk45ayvKJBPDpNCqgN4x5MTjcm7IYyxE1Eq8uGuK/fHcj 4QHN26LmAMC5vNJsuZzP2vcWbHN4wxCTnzgk67Al3296/c2vIgb2V5/iZMD9gem/+ry/od XwjImu1xKC1pREWD/Blb+Vy9aZqXyelCNF6dveeOOimTDoX8TwMG7X2PXYvU+nPJXVDT/c /nUMSxstgHX31qyNP6QGkJXx1bqHjg8C13OITvoMDn0OfMXRhYTkjMdSR0v4NW/VgnPA8+ L8EDcZpAFV1/2NV1gDjx6NGFJeqyb/Tmw9LG2Oza+ytBOhSIE/UnQs0er0t/ZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MHYzgKCC; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689241959; a=rsa-sha256; cv=none; b=T0QQqSskSvlaEsoncXqEB0mYNHvr3Y9iMhLBmEOBqGsYf0mU1srjcI9BeyPKqczbHK9v69 AEL0SdG6R+15q1lK04X3Zo2n/SUMNJGwHkbYWOA7xiuiA9HaUUAEvzkTLTS4cRGLdKgM+f AQeC8d6SQptswU7qgx7h4Gvowr3zHvvWzpBvtsgH+Z34Khdsmg+EB7aJIwVgcB1wylKyFu rVxVFIkre+U246y8rk3mPki2Cx6m0LwoQ5cCyTsB+IGbpjaCDCloG9gtcaq9ST4r3A0i0M qOtvIe4V7WaOH//j8Rkidwv58/PtudLIGc2CfcLGv/2l5xs23vwMZA9loNHlWg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJsz1-0006U7-8T; Thu, 13 Jul 2023 05:51:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJsyx-0006Tw-PP for emacs-orgmode@gnu.org; Thu, 13 Jul 2023 05:51:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJsyv-0003TE-0H for emacs-orgmode@gnu.org; Thu, 13 Jul 2023 05:51:31 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2176524002D for ; Thu, 13 Jul 2023 11:51:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689241885; bh=fBG4csREDYAkIapZBJu6A0OLISBUSpaK8L3fvsuPRpQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=MHYzgKCC/Qam7WGYvc4iIJlHnrVU76chuzWSk+s5G8XxeEnlfKKbZB2GALz/gnEzv 6/wR11BcYKHHqgYOHFAtAKn70BIKimZtuKpf8EoVj7Etesr88yKZ0cOHAYhRcL1mii 6H7JYVsmW86QuQJzRORfT1YH8Kr1ws0fj2JkM94mOT3UIkiSsbBa50NV0LpXCKCwjN BD0bc6PCwGfUy8W9qITotIveRvhW7AAkQJzNm3h59pPpTfceBVJcwwz0Bwtq5FzQNl QW/heMTSijKXsiw3KV1pFIiHJGbhoRNAJxC4L5WauxTGaaJbAMUWE2wtbGtDcLNrcN kKgmZenNJ0Fqw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1qcr379Dz6trs; Thu, 13 Jul 2023 11:51:24 +0200 (CEST) From: Ihor Radchenko To: Ilya Chernyshov Cc: emacs-orgmode Subject: Re: [PATCH] testing: Delete duplicate tests In-Reply-To: <87cz0xndem.fsf@gmail.com> References: <87cz0xndem.fsf@gmail.com> Date: Thu, 13 Jul 2023 09:51:33 +0000 Message-ID: <87cz0wyw9m.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.07 X-Migadu-Queue-Id: 6D745400FC X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -9.07 X-TUID: c5KuPHXbhf5P Ilya Chernyshov writes: > In my last patch, I found a duplicate test, so I decided to find all of > the duplicate tests inside testing/lisp/ folder via this function: Thanks! > --- a/testing/lisp/test-org-table.el > +++ b/testing/lisp/test-org-table.el > @@ -3368,10 +3368,6 @@ See also `test-org-table/copy-field'." > (org-test-with-temp-text "| 1 | 2 | 3 |" > (org-table-get-field 3 " foo ") > (buffer-string)))) > - (should > - (equal " 4 " > - (org-test-with-temp-text "| 1 | 2 |\n| 3 | 4 |" > - (org-table-get-field 2)))) It looks like the real test is supposed to be (equal " foo " ... (org-table-get-field 2 " foo ") (buffer-string) > --- a/testing/lisp/test-org.el > +++ b/testing/lisp/test-org.el > @@ -994,14 +994,6 @@ > (org-auto-fill-function) > (buffer-string))))) > ;; Comment block: auto fill contents. > - (should > - (equal "#+BEGIN_COMMENT\n12345\n7890\n#+END_COMMENT" > - (org-test-with-temp-text "#+BEGIN_COMMENT\n12345 7890\n#+END_COMMENT" > - (let ((fill-column 5)) > - (forward-line) > - (end-of-line) > - (org-auto-fill-function) > - (buffer-string))))) > (should > (equal "#+BEGIN_COMMENT\n12345\n7890\n#+END_COMMENT" > (org-test-with-temp-text "#+BEGIN_COMMENT\n12345 7890\n#+END_COMMENT" And this is the result of 8a97c60 Do not fill verse blocks contents * lisp/org.el (org-fill-context-prefix, org-fill-paragraph): Do not fill verse blocks contents. Verse blocks can be used to format free-form poetry, so filling has to be done manually. * testing/lisp/test-org.el: Remove unnecessary tests. The test was changed from testing verse block into a duplicate. I think the right thing to do here would be `should-not' + old version of the test with VERSE block. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at