From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Testing: Ensure 'org-id-locations-file' is set before updating
Date: Wed, 19 Jul 2023 08:04:07 +0000 [thread overview]
Message-ID: <87cz0omio8.fsf@localhost> (raw)
In-Reply-To: <DM5PR03MB316333DCE671ED9D89C73AD3C538A@DM5PR03MB3163.namprd03.prod.outlook.com>
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> Previously, when trying to run the tests in a container limited to the
> org repository, it fails because it can't create the directory
> "~/.emacs.d/.org-id-locations".
>
> * testing/org-test.el (org-test-load): Move setting
> 'org-id-locations-file' from here ...
> org-test-update-id-locations: ... to here
> ---
>
> Hello! This fix allows me to run the tests without giving it access to the
> filesystem outside of the repository. I have no clue what org-id-locations are
> and I'm hoping someone else does so I don't have to learn. I'm not sure if
> this is the best fix, but it works.
The whole
(defconst org-test-dir
(expand-file-name (file-name-directory (or load-file-name buffer-file-name))))
is fishy when users attempt to run tests from normal Emacs session.
If you had issues with this variable from batch invocation, something
should be fixed in the defconst, I think.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-19 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 16:40 [PATCH] Testing: Ensure 'org-id-locations-file' is set before updating Morgan Smith
2023-07-19 8:04 ` Ihor Radchenko [this message]
2023-08-12 9:29 ` Ihor Radchenko
2023-08-12 14:26 ` Max Nikulin
2023-08-13 8:30 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz0omio8.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Morgan.J.Smith@outlook.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).