emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jack Kamm <jackkamm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>, Henrik Frisk <frisk.h@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: ICalendar export
Date: Sat, 16 Sep 2023 15:52:26 -0700	[thread overview]
Message-ID: <87cyyhspcl.fsf@gmail.com> (raw)
In-Reply-To: <87pm2mh597.fsf@localhost>

Ihor Radchenko <yantar92@posteo.net> writes:

> Henrik Frisk <frisk.h@gmail.com> writes:
>
>> Recently (not sure when) the ics output came out malformed and a newline is
>> omitted between the end of one event and the beginning of another:
>>
>> END:VEVENT
>> BEGIN:VEVENT
>>
>> is now
>>
>> END:VEVENTBEGIN:VEVENT
>>
>> I can't figure out wha the pattern is, for some events the output is
>> correct.
>>
>> This is on Org mode version 9.7-pre release_9.6.8-719-gf299fb and emacs 29.1
>
> We recently did some major changes to comply better to the icalendar
> specs and introduced new feature. As it usually goes, major changes can
> easily introduce new bugs.
>
> Does the attached patch fix the problem for you?

I can reproduce the bug by calling `org-icalendar-export-current-agenda'
in my agenda buffer. It seems to mainly happen when subsequent agenda
entries originate from different files.

Ihor's patch fixes the problem on my end.

Bisecting, the bug was introduced in f4446ce79.


  reply	other threads:[~2023-09-16 22:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 12:01 ICalendar export Henrik Frisk
2023-09-13  8:00 ` Ihor Radchenko
2023-09-16 22:52   ` Jack Kamm [this message]
2023-09-17  9:50     ` Ihor Radchenko
2023-10-04  9:32       ` Henrik Frisk
  -- strict thread matches above, loose matches on Subject: below --
2011-07-20 12:19 iCalendar export Gustav Wikström
2011-07-20 18:05 ` Tassilo Horn
2011-07-21  9:35   ` Bastien
2011-07-25 23:14     ` Arun Persaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyyhspcl.fsf@gmail.com \
    --to=jackkamm@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=frisk.h@gmail.com \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).