emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@posteo.net>
To: Noboru Ota <me@nobiot.com>
Cc: emacs-orgmode@gnu.org, salutis@me.com
Subject: Re: Radio links work only in small numbers
Date: Thu, 29 Feb 2024 11:11:10 +0000	[thread overview]
Message-ID: <87cysfo78x.fsf@localhost> (raw)
In-Reply-To: <8634tcp717.fsf@nobiot.com>

Noboru Ota <me@nobiot.com> writes:

>> You need Www.
>> The attached version of the patch should work for 5000-terms.org.
>
> Thank you, Ihor. With your advice, I have managed to apply the patch. It
> works for 5000 terms! Thank you.

Thanks for testing!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=341a01a07
Fixed.

> Some observations:
>
> - Running `org-update-radio-target-regexp` takes about 15 seconds for the
>   file[1].

This is expected. By splitting radio target regexp into multiple
regexps, we increase the number of regexp search invocations. Regexp
search is relatively costly in Emacs.

>> (I had to scale down the maximum allowed regexp size; apparently,
>> the number from C sources was not small enough).
>
> Do you have any indication on how many would be maximum?

See the docstring of `org-target-link-regexp-limit'.
The hard limit is MAX_BUF_SIZE in src/regex-emacs.c, but that's after
the regexp is compiled (AFAIU). So, the real limit is smaller and may
depend on regexp complexity.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2024-02-29 11:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 23:10 Radio links work only in small numbers Rudolf Adamkovič
2022-12-14  8:30 ` Ihor Radchenko
2022-12-14 15:29   ` Rudolf Adamkovič
2022-12-14 15:47 ` Max Nikulin
2022-12-14 16:02   ` Ihor Radchenko
2022-12-20  3:21     ` Timothy
2022-12-20  1:00   ` Rudolf Adamkovič
2022-12-28  9:46 ` Daniel Clemente
2024-02-19  9:26 ` Ihor Radchenko
2024-02-28 16:33   ` nobiot
2024-02-28 17:14     ` Ihor Radchenko
2024-02-28 22:18       ` Noboru Ota
2024-02-29 11:11         ` Ihor Radchenko [this message]
2024-02-29 16:47           ` Noboru Ota
2024-02-29 17:21             ` Ihor Radchenko
2024-02-29 17:44               ` Noboru Ota
2024-04-04 20:20           ` Rudolf Adamkovič

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cysfo78x.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=me@nobiot.com \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).