From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qPy9M0WcK2aUaAAAe85BDQ:P1 (envelope-from ) for ; Fri, 26 Apr 2024 14:21:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id qPy9M0WcK2aUaAAAe85BDQ (envelope-from ) for ; Fri, 26 Apr 2024 14:21:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PLDUyt6e; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714134085; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5c7ZQEcVnRyBLAXcgiLLjkpiFX4Nslm5tElo0zivdSQ=; b=V5ef69eiuG+eX/ccgQbbYKxYNAbemknYNMrug3fVkGAZ0St7wAgCwluFjydFlEVJH7vUjx PUS63niEaSoqQeBTkDeZe5pdjB0C7LwUKyKTHai+cJcR1VZWQ6lTzEkbof/eH0aPy6AF4I jt1/iMQj6z/75lN0ecMFU2uiKok8PP+ZwGCyXtT6WpoL1Kn6wyvAARDWjdH0faFpVFUhZb AcbV69C8meO9CeQLXVhySPHH1PXVXKaS28c3ZO1LvI3aAz/caCGqjPCsNoQ8ZSJw8nQAjC 5dS744hXTAwPLSDP2lCTmUZ72BfQ2KqYB37TPPlBZbVvKIa9oJ1CtEWA5GzVPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PLDUyt6e; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714134085; a=rsa-sha256; cv=none; b=TBDxP2ektIe/N1HkFPGF5+I0ifiONVODBFkpO/pu9i0C4vKB7M640imOM7KZJgvzIly7YT m9YrnyO/8wo5BzvTIF+jYWa9m9NQAZjwf3RGKMQL02kf3ahzPAoFrqWDFjl/5DHyFWkGBH drTMQTS1k4K9hMJXcuWC0CnDIMXDRgHdEChjF33QawxoYPu4TgVCOWsxr4ItpJFM1phlYo qyuk8GNRwN0xzOgSCAlnbnt2J+M6q4zaGpNwcjGqsLBdfFuhiA5mZCzk94TVjM6kdhpMBd +SVR8Q/kwM5R/G8f5ccEWe9V/t9Q+/mpphcLneMCiDcSVXRoDIGSuQcrss5qbw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 761443694 for ; Fri, 26 Apr 2024 14:21:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0KZ6-0000BV-1G; Fri, 26 Apr 2024 08:20:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0KZ4-0000BL-8W for emacs-orgmode@gnu.org; Fri, 26 Apr 2024 08:20:30 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0KZ2-0003vq-Al for emacs-orgmode@gnu.org; Fri, 26 Apr 2024 08:20:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E330B240101 for ; Fri, 26 Apr 2024 14:20:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714134024; bh=Yi67mDfUS5yIt2T8/eQ0smBoE/aYDDI9uT6j+tq/yH0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=PLDUyt6etGZdQgUmGi2TPgUEu8WaBTiO+BiwhuP5rLDaP5ZBwRt7CPyN4vDQsKLS8 C2yrZLlSzAzeRaq7tXkMFF7B+blNZowhhZQSd5Dy0PogaYsJhz6gpBw7ON56dZkt8m U9CAyfNhTWf2CAMSaGOXcUiXrjw3DLnKF6xl8rQoDIwmElg/TNzXpZcKtLusiVByrE SZF432u2j2uj2Vv/NMdbfHNXSG8upGqnpsiKr5jaBzLBRI/E26XY3hwVnpfrBISmHG oBmF9P9cXr7H5UWSfhXYNgTzskfoRvGcAyq6JRXlEFN9mbK8x0FTdFspVbG+5HcG3o Te1D0wbg4K3UA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VQsHq6Gyqz6tvq; Fri, 26 Apr 2024 14:20:23 +0200 (CEST) From: Ihor Radchenko To: Alexander Adolf , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM In-Reply-To: <58b5fd0f869e36bf7a62b4e68286f90e@condition-alpha.com> References: <486d2b818b62c71b3f307305c06c4318@condition-alpha.com> <871q7cypxl.fsf@localhost> <00aa9bf72dc93f6554bdd236fdfba192@condition-alpha.com> <87y19hbb05.fsf@localhost> <8b72386d118136210f27b553f0a13066@condition-alpha.com> <87cyqtyzgt.fsf@localhost> <91dfeb0fed1a1fe0564e5eb9b95a409d@condition-alpha.com> <87a5lpeiey.fsf@localhost> <87zftp6zz3.fsf@localhost> <98f04a910f31ff9ab38e2ddf9e7f2f5c@condition-alpha.com> <87mspmq1ce.fsf@localhost> <117e93f189241f4800af207ce30aa606@condition-alpha.com> <87zftkpbbf.fsf@localhost> <87h6fs11h8.fsf@localhost> <58b5fd0f869e36bf7a62b4e68286f90e@condition-alpha.com> Date: Fri, 26 Apr 2024 12:21:24 +0000 Message-ID: <87cyqcuxff.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.01 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.01 X-Migadu-Queue-Id: 761443694 X-TUID: TI25iGEgmPP0 Alexander Adolf writes: > Ihor Radchenko writes: > >> [...] >>>> If you can, please add some more tests like mine checking >>>> `org-columns--clean-item'. >> [...] > > I have added one test for each new feature (headline linkification, and > formatting function). Also, there's a third patch, which moves the call > to `org-quote-vert' to the cleanup function `org-columns--clean-item' as > you suggested. > > Updated patches below. Thanks! The patch is ready to be merged. Bastien, may you please confirm the FSF records? Alexander should have the copyright signed. > One more thing caught my eye in `org-dblock-write:columnview' though. > When running the currently (i.e. before my patches) last test in > test-org-colview.el, the one with `org-columns-default-format' set to > "%ITEM %DEADLINE(d) %SCHEDULED(s) %TIMESTAMP(t)", `org-with-wide-buffer' > appears to modify the buffer and advances point by one (before the call > point is at 97, after the call at 98). In all other tests, > `org-with-wide-buffer' does not move point. In > `org-dblock-write:columnview' I have thus moved the sampling of point > for passing to the formatting function to after the call to > `org-with-wide-buffer'. This is expected - `org-dblock-write:columnview' uses `org-columns--capture-view', which, in turn, calls the `org-columns' - function used to create an interactive column view. For interactive column view, we must have at least a single space for each column. Otherwise, we cannot display the columns overlay. So, `org-columns' always add spaces to headlines, when there are not enough of them to fit all the requested columns. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at