From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Seltenreich Subject: 23.0.94; [PATCH] org-store-link broken within kbd macros Date: Wed, 17 Jun 2009 13:15:38 +0200 Message-ID: <87bponi011.fsf@gate450.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGt7W-00073S-MS for emacs-orgmode@gnu.org; Wed, 17 Jun 2009 07:15:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGt7Q-00072q-PL for emacs-orgmode@gnu.org; Wed, 17 Jun 2009 07:15:57 -0400 Received: from [199.232.76.173] (port=60600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGt7Q-00072m-MG for emacs-orgmode@gnu.org; Wed, 17 Jun 2009 07:15:52 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-pretest-bug@gnu.org Cc: emacs-orgmode@gnu.org > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: org-store-link works fine when recording a keyboard macro but it is a NOP when executing it. The following change appears to fix it. regards, andreas > In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu) > of 2009-05-28 on tengen --8<---------------cut here---------------start------------->8--- *** org.el.~1.48.~ 2009-02-20 10:02:49.000000000 +0100 --- org.el 2009-06-17 12:55:15.000000000 +0200 *************** *** 6594,6600 **** desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) ! (if (and (interactive-p) link) (progn (setq org-stored-links (cons (list link desc) org-stored-links)) --- 6594,6600 ---- desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) ! (if (and (or (interactive-p) executing-kbd-macro) link) (progn (setq org-stored-links (cons (list link desc) org-stored-links)) --8<---------------cut here---------------end--------------->8---