From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 0/2] org-version fix for windows Date: Thu, 20 Aug 2009 15:06:08 -0400 Message-ID: <87bpmas3tr.fsf@gollum.intra.norang.ca> References: <87vdkju8lc.fsf@gollum.intra.norang.ca> <1250712378-16345-1-git-send-email-bernt@norang.ca> <877hwzrvh5.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeCxm-00022e-HC for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:06:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeCxh-0001wZ-Vo for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:06:17 -0400 Received: from [199.232.76.173] (port=38648 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeCxh-0001wL-R1 for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:06:13 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:64958) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeCxh-0004l8-8d for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:06:13 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org Hi Carsten, As it turns out these patches are okay. Manish retested them on his system today and they work. Please apply. Both of these commits are available at git://git.norang.ca/org-mode for-carsten Regards, Bernt PS: Manish> Thanks for testing!! Bernt Hansen writes: > Carsten, > > Please do NOT apply these patches yet. Manish reported a problem with > them on his system. I'll post improved ones tomorrow. > > Thanks, > Bernt > > > Bernt Hansen writes: > >> Here are two patches which fix org-version for windows. >> >> This should handle cygwin and msysGit where git is installed for use >> by the default Windows command shell. This does not currently support >> msysGit where git is not installed in the user's PATH. >> >> The series is available at git://git.norang.ca/org-mode for-carsten >> >> Bernt Hansen (2): >> Use lisp cd function to change directories to avoid shell >> dependencies >> Skip git-version determination if git command fails >> >> lisp/org.el | 42 +++++++++++++++++++++++------------------- >> 1 files changed, 23 insertions(+), 19 deletions(-)