emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: David Maus <dmaus@ictsoc.de>
To: Sebastian Rose <sebastian_rose@gmx.de>
Cc: "David Maus" <dmaus@ictsoc.de>,
	emacs-orgmode@gnu.org,
	"Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Subject: Re: [bug] org-link-escape and (wrong-type-argument stringp	nil)
Date: Sun, 26 Sep 2010 20:22:46 +0200	[thread overview]
Message-ID: <87bp7kicuh.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <87d3s48c8c.fsf@gmx.de>


[-- Attachment #1.1: Type: text/plain, Size: 1944 bytes --]

Sebastian Rose wrote:
>David Maus <dmaus@ictsoc.de> writes:
>>>  sh$  man utf-8
>>
>> Thanks!  I finally get a grip on one of my personal nightmares.


>It's not that bad, is it? :D

Even better: It makes sense ;)

>> The attached patch is the first step in this direction: It modifies
>> the algorithm of `org-link-escape', now iterating over the input
>> string with `mapconcat' and escaping all characters in the escape
>> table or are between 127 and 255.

>Between 128 (1000 0000) and 255 ??

>The binary representation of 127 is 0111 1111 and valid ascii char. DEL
>actually (sh$ man ascii)

Right, and that's why it is encoded: No control characters in a URI.

The final algorithm for the shiny new unicode aware percent encoding
function would be:

 - percent encode all characters in TABLE
 - percent encode all characters below 32 and above 126
   - encode the char in utf-8
   - percent escape all bytes of the encoded char

The remaining problem is keeping backward compatibility. There are Org
files out there where "á" is encoded as "%E1" and not "%C3A1".  The
percent decoding function should be able to recognize these old
escapes and return the right value.  

I looks like this could be done by changing the behavior of
`org-protocol-unhex-string'.  Currently it returns the empty string
for "%E1" because it does not represent a valid utf-8 encoded unicode
char.  Maybe we could say: If the percent encoded sequence does not
form a valid char, use the old method (extended ASCII?) to decode the
sequences.

Sadly (or luckily?) chances are good that I will be somewhat offline
for the next two weeks -- I think implementing this unicode aware
escaping function should be the way to go but requires some careful
checking for it's consequences for old Org files.

Best,
  -- David

-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2010-09-26 18:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 12:42 [bug] org-link-escape and (wrong-type-argument stringp nil) Sébastien Vauban
2010-09-20 18:57 ` David Maus
2010-09-20 19:31   ` Sebastian Rose
2010-09-22  7:19     ` David Maus
2010-09-22 14:25       ` Sebastian Rose
2010-09-23 18:40         ` David Maus
2010-09-23 19:57           ` Sebastian Rose
2010-09-26 18:22             ` David Maus [this message]
2010-09-26 21:23               ` Sebastian Rose
2010-09-26 22:43               ` Sebastian Rose
2010-09-26 22:47               ` Sebastian Rose
2010-09-26 22:51               ` Sebastian Rose
2010-09-27  5:36                 ` [PATCH] " David Maus
2010-09-27 12:43                   ` Sebastian Rose
2010-09-29 15:48                   ` Carsten Dominik
2010-09-27  5:36                 ` [PATCH] Decode single byte sequence if decoding unicode failed David Maus
2010-11-04 20:35                 ` [bug] org-link-escape and (wrong-type-argument stringp nil) David Maus
2010-09-20 19:49   ` Sébastien Vauban
2010-09-22  7:20     ` David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bp7kicuh.wl%dmaus@ictsoc.de \
    --to=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=sebastian_rose@gmx.de \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).