From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Re: [PATCH] Alphabetical ordered lists Date: Mon, 22 Nov 2010 19:37:41 +0100 Message-ID: <87bp5hi4qy.wl%n.goaziou@gmail.com> References: <87bp8o498o.fsf@gollum.intra.norang.ca> <393C5110-E4D3-4B36-8F4E-4F94B5AA0F93@gmail.com> <87k4m876g3.wl%n.goaziou@gmail.com> <87iq1r7k00.wl%n.goaziou@gmail.com> <747F5104-6B1C-43E8-BF42-883287B7E303@gmail.com> <87aan0789y.wl%n.goaziou@gmail.com> <874od127wq.wl%n.goaziou@gmail.com> <535BC60F-1310-47AD-BCD1-1C88822B852A@gmail.com> <87y69lqs8z.wl%n.goaziou@gmail.com> <4849E760-2A8F-49A4-9B29-347BD3645D1A@gmail.com> <87r5ep2r0k.wl%n.goaziou@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from [140.186.70.92] (port=45817 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKbGs-0004ee-Fs for emacs-orgmode@gnu.org; Mon, 22 Nov 2010 13:37:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKbGr-0000RO-7p for emacs-orgmode@gnu.org; Mon, 22 Nov 2010 13:37:46 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:47095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKbGr-0000R9-20 for emacs-orgmode@gnu.org; Mon, 22 Nov 2010 13:37:45 -0500 Received: by wwc33 with SMTP id 33so7908023wwc.30 for ; Mon, 22 Nov 2010 10:37:43 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nathaniel Flath Cc: Bernt Hansen , Jacob Mitchell , org-mode List , Carsten Dominik Hello, >>>>> Nathaniel Flath writes: > although I'm not an expert in the exporting. Let me know if there's > anything else, or if I screwed up anything when trying to figure out > how to make a git patch(looks like it worked, though.) I looked at your patch and here is what I've noticed so far: - There's a bug in `org-cycle-list-bullet' where org-list-can-be-alphabetical is called with argument missing. - In `org-cycle-list-bullet', variable `top' stores list top point, make use of it instead of recomputing it. - There's a typo in `org-list-parse-list' (ogr-looking-at-p instead of org-looking-at-p) - Some parts of the patch are only white-space changes (for example a change in `org-list-automatic-rules' but there are others). You shouldn't include them, as it is not the purpose of the patch. It doesn't help understanding your patch either. - Why did you remove all code comments about lists in org-docbook.el? - This is not a bug but are you sure you want to make org-item-beginning-re a function? I understand that it permits an user changing the value of `org-alphabetical-lists' to avoid reloading Org, but it looks like syntax overweight to me. I mean, anyone wanting to look for a list item will have to remember that it must do a re-search on a function and not a string. Hoping that helps, Regards, -- Nicolas