From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 1/4] Rename org-agenda-today to org-today. Date: Wed, 01 Dec 2010 08:26:04 -0500 Message-ID: <87bp55d3pv.fsf@gollum.intra.norang.ca> References: <1291040314-1884-1-git-send-email-julien@danjou.info> <003742C3-1C32-4B05-973E-B368F769E8DD@gmail.com> <87aakrp4dr.fsf@keller.adm.naquadah.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=54949 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNmhP-0003Qn-Rp for emacs-orgmode@gnu.org; Wed, 01 Dec 2010 08:26:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNmhN-0006es-TW for emacs-orgmode@gnu.org; Wed, 01 Dec 2010 08:26:19 -0500 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:65063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNmhN-0006cW-Rb for emacs-orgmode@gnu.org; Wed, 01 Dec 2010 08:26:17 -0500 In-Reply-To: <87aakrp4dr.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Tue, 30 Nov 2010 10:06:24 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Julien Danjou Cc: emacs-orgmode@gnu.org, Carsten Dominik Julien Danjou writes: > On Tue, Nov 30 2010, Carsten Dominik wrote: > >> the purpose of this change is .... to be able to use >> this also in org.el without having to load org-agenda.el? > > Yes, and to be consistent. The variable org-extend-today-until is > defined in org.el, it seems more general than org-agenda, i.e. it has no > sense to be defined as an agenda function. Hi Julien, These details should be in the commit message text when you post patches to the list. My initial reaction to your patches was 'Why do we need this?' Please add enough detail in the commit message text in the future so the purpose of the patch is clearly stated. Thanks, Bernt