emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Ethan Ligon <ligon@are.berkeley.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Problem with html export of description list items
Date: Thu, 07 Apr 2011 14:51:06 +0200	[thread overview]
Message-ID: <87bp0i5io5.fsf@gmail.com> (raw)
In-Reply-To: <loom.20110406T023109-364@post.gmane.org> (Ethan Ligon's message of "Wed, 6 Apr 2011 00:38:36 +0000 (UTC)")

Hello,

Ethan Ligon <ligon@are.berkeley.edu> writes:

> Ethan Ligon <ligon <at> are.berkeley.edu> writes:
>> 
>> I've just stumbled across what I regard as a bug in the html export of
>> description list items.
>> 
>> The problem has to do with whether the specification of a description
>> list includes a trailing space or not; i.e., whether "- Item ::" is
>> treated the same way as "- Item :: ".  LaTeX export treats these as
>> identical.  Html export gets confused about what the description list
>> item is, and winds up generating a "???" for the description.

LaTeX exporter doesn't treats these as identical. What happens is that
in your example, the first item is correct and the list is thus set as
a description list. As such, LaTeX exporter tries hard to fill
description terms for every item in the list. If you exchange the first
and second items in your example, the list will be exported as
a standard itemize list in LaTeX.

For HTML (and DocBook) exporter, this is a little different, and term
recognition is hard-coded there. I will modify that.

> Having done the work to describe the problem, it wasn't hard to find a
> solution.  In this case that's a one character change to a regexp in
> org-html.el. 
>
> Here's the patch:
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index d19d88b..005a0f7 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -2501,7 +2501,7 @@ the alist of previous items."
>         (concat "[ \t]*\\(\\S-+[ \t]*\\)"
>                "\\(?:\\[@\\(?:start:\\)?\\([0-9]+\\|[A-Za-z]\\)\\]\\)?"
>                "\\(?:\\(\\[[ X-]\\]\\)[ \t]+\\)?"
> -              "\\(?:\\(.*\\)[ \t]+::[ \t]+\\)?"
> +              "\\(?:\\(.*\\)[ \t]+::[ \t]*\\)?"
>                "\\(.*\\)") line)
>        (let* ((checkbox (match-string 3 line))
>              (desc-tag (or (match-string 4 line) "???"))

Your patch allows items like:

- term ::description

which are not valid for a description list.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2011-04-07 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06  0:07 [Bug] " Ethan Ligon
2011-04-06  0:38 ` [PATCH] " Ethan Ligon
2011-04-07 12:51   ` Nicolas Goaziou [this message]
2011-04-07 21:52     ` Ethan Ligon
2011-04-08 11:53       ` Nicolas Goaziou
2011-04-08 17:46         ` [PATCH] Fix for html & docbook " Ethan Ligon
2011-04-09  3:19         ` [PATCH] Problem with html " Ethan Ligon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bp0i5io5.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ligon@are.berkeley.edu \
    --subject='Re: [PATCH] Problem with html export of description list items' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).