* [PATCH] Small fix for contrib/lisp/org-elisp-symbol.el
@ 2011-09-02 4:53 David Maus
2011-09-06 16:12 ` Bastien
0 siblings, 1 reply; 2+ messages in thread
From: David Maus @ 2011-09-02 4:53 UTC (permalink / raw)
To: emacs-orgmode; +Cc: bzg
[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]
Attached patch fixes a small issue with
contrib/lisp/org-elisp-symbol.el, a contributed package that defines a
link type for elisp symbols.
Currently org-elisp-symbol.el uses `eq' to compare a symbol value with
a string. Such a comparism always evals to nil:
#+begin_src emacs-lisp
(let ((foo "foo"))
(eq foo "foo")) => nil
#+end_src
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #1.2: 0001-Use-string-to-compare-strings.patch --]
[-- Type: text/plain, Size: 1070 bytes --]
From 4b5d2e726d8f64e111c42623ae0cd5cf8d82ad70 Mon Sep 17 00:00:00 2001
From: David Maus <dmaus@ictsoc.de>
Date: Thu, 1 Sep 2011 06:49:29 +0200
Subject: [PATCH] Use `string=' to compare strings
* org-elisp-symbol.el (org-elisp-symbol-store-link): Use `string=' to
compare strings.
(let ((foo "foo"))
(eq foo "foo")) => nil
---
contrib/lisp/org-elisp-symbol.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-elisp-symbol.el b/contrib/lisp/org-elisp-symbol.el
index e614e97..6eb8114 100644
--- a/contrib/lisp/org-elisp-symbol.el
+++ b/contrib/lisp/org-elisp-symbol.el
@@ -104,8 +104,8 @@
(stype (cond ((commandp sym-name) "Command")
((functionp sym-name) "Function")
((user-variable-p sym-name) "User variable")
- ((eq def "defvar") "Variable")
- ((eq def "defmacro") "Macro")
+ ((string= def "defvar") "Variable")
+ ((string= def "defmacro") "Macro")
(t "Symbol")))
(args (if (match-string 3)
(mapconcat (lambda (a) (unless (string-match "^&" a) a))
--
1.7.2.5
[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Small fix for contrib/lisp/org-elisp-symbol.el
2011-09-02 4:53 [PATCH] Small fix for contrib/lisp/org-elisp-symbol.el David Maus
@ 2011-09-06 16:12 ` Bastien
0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2011-09-06 16:12 UTC (permalink / raw)
To: David Maus; +Cc: emacs-orgmode
David Maus <dmaus@ictsoc.de> writes:
> Attached patch fixes a small issue with
> contrib/lisp/org-elisp-symbol.el, a contributed package that defines a
> link type for elisp symbols.
Applied, thanks!
--
Bastien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-06 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-02 4:53 [PATCH] Small fix for contrib/lisp/org-elisp-symbol.el David Maus
2011-09-06 16:12 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).